FIX Guzzle Client options can be configured by extensions #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Common Web Platform, or any other network that requires a proxy for outgoing HTTP requests, we need to configure the proxy settings before these requests get made.
Request points:
This PR adds configurability to the ApiLoader, while the Update Checker can be configured using
$_SERVER['CGI_HTTP_PROXY']and Security Checker via HTTP_PROXY and HTTPS_PROXY environment variables and will be detected automatically.The ApiLoader uses Guzzle which needs these defined explicitly, and the update checker uses Composer which creates its own stream context, therefore also needs to be configured. Clients like CWP can define input points such as
$_SERVER['CGI_HTTP_PROXY']before theComposerLoaderExtension::onAfterBuildis run which is the point that Composer is created with its config.Probably more of a minor semver change but I'd like to treat this as a patch since it's fixing a bug and is backwards compatible.
Fixes #113