Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Guzzle Client options can be configured by extensions #114

Merged
merged 1 commit into from
Jun 26, 2018
Merged

FIX Guzzle Client options can be configured by extensions #114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions src/Util/ApiLoader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ abstract class ApiLoader
use Extensible;

private static $dependencies = [
'GuzzleClient' => '%$GuzzleHttp\Client',
'GuzzleClient' => '%$' . Client::class,
];

/**
Expand Down Expand Up @@ -62,7 +62,7 @@ public function doRequest($endpoint, callable $callback)

try {
/** @var Response $response */
$response = $this->getGuzzleClient()->send($request, ['http_errors' => false]);
$response = $this->getGuzzleClient()->send($request, $this->getClientOptions());
} catch (GuzzleException $exception) {
throw new RuntimeException($failureMessage);
}
Expand Down Expand Up @@ -112,6 +112,20 @@ public function setGuzzleClient(Client $guzzleClient)
return $this;
}

/**
* Get Guzzle client options
*
* @return array
*/
public function getClientOptions()
{
$options = [
'http_errors' => false,
];
$this->extend('updateClientOptions', $options);
return $options;
}

/**
* Attempts to load something from the cache and deserializes from JSON if successful
*
Expand Down