-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't use module on CWP platform #113
Comments
Give it a god, but not sure if this will work as this would rely on |
Is this issue relevant to SSP as well? |
Yep, just tested |
|
Ok, now hitting a blocker with the CWP proxy (related: silverstripe/silverstripe-cms#2168). Will need to see if we can inject this config somehow |
Nice work! |
Need to backport change for the CWP 1.9 recipe too |
I'd like to also point out that while we've achieved resolution in the context of which we are testing, I think this issue spans wider than just CWP (or the recipe of such at least), indicated in the fact that it also affected SSP - and while it works again now, it's because we're testing it in the context of a CWP recipe. The fix: Meaning anyone not using CWP (at least the module, but in the broader sense the platform as a whole) will still be affected by this exception any time they attempt to retrieve the task list (or run the task itself) from a user that does not have these environment variables set. However if I were betting inclined, I'd wager that this will affect any web server that runs as it's own user - typically a non-login user meaning an absence any profile setup files... and in many a case it's a system user (UID lower than 1000) which can also mean there is no Exemplified in the virtual environment I was finally able to recreate this issue; there was nothing special about it's setup that I would consider unusual. At this point I'd like to suggest moving this composer environment variable check (i.e. not the proxy ones from the same class) to that in which the exception manifests - |
Sure, I'll do that |
Ideal, all done! Thanks @robbieaverill |
I've merged all the branches up. |
Tested CWP 1.9 and 2.1 on CWP platform, all good! |
Whoops, the task doesn't run in 1.9 on CWP |
Falsy, forgot to deploy the updated 1.9 CWP code 🤦♂️ |
When trying to run the report generation task on the CWP platform we get this error in the failed job output:
@sminnee suggested that he'd fixed the same error on the addons site by defining COMPOSE_HOME as one of your project variables in platform configuration, though for a default CWP site we'd rather define a fallback in code if it's not defined already, e.g.
Needs testing too of course
Pull requests
Tested on CWP and SSP
The text was updated successfully, but these errors were encountered: