FIX Maintenance module extension now provides CWP proxy information for HTTP requests #125
Conversation
| use SilverStripe\Core\Environment; | ||
| use SilverStripe\Core\Extension; | ||
|
|
||
| if (!class_exists(SiteSummary::class)) { |
There was a problem hiding this comment.
FYI this does nothing as the class below is still compiled...
There was a problem hiding this comment.
Are you sure? This is a common pattern in SilverStripe
There was a problem hiding this comment.
Pretty sure... I just tested it with this gist: https://gist.github.com/ScopeyNZ/7ad38ff41f3bdc03dd2141474e0793df
There was a problem hiding this comment.
I find this information mildly perplexing. As Robbie said, it is (or at least was) all throughout the core code, and various modules. Is it perhaps a PHP version thing?
There was a problem hiding this comment.
We discussed this yesterday - I'm pretty sure it's needed for when the ClassManifest gets regenerated, but only when extending a class that doesn't always exist. In this case it's not required since Extension is always there
There was a problem hiding this comment.
Well I'm learning a lot about the PHP compiler today. Logical expressions (non-declarative code) are usually ignored at compile time. The compiler considers all class definitions.
- If the extended class exists then the class is defined and the
ifstatement does nothing. - If the extended class does not exist but you have the
ifstatement then theifstatement is respected and you don't get an error unless you try to instantiate the class (that's doing the extending). The error will be that the class that's doing the extending does not exist. - If you don't have the
ifstatement then PHP will fatal at compile time and let you know the extended class does not exist.
PHP...
See bringyourownideas/silverstripe-maintenance#114 for background information.
Issue: bringyourownideas/silverstripe-maintenance#113