Import p2p keys #8771
Closed
Import p2p keys #8771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes brave/brave-browser#15690 Due to the cr91 upstream change below the omnibox selection color is now the same color as the focus ring of the omnibox. Since we override the focus ring to be our brand color, the selection is now also the brand color, which we don't want. This fix reverts the omnibox selection color to what it was in cr90 (kGoogleBlue200 for Light theme, kGoogleBlue800 for Dark). Chromium changes: This change redefined kColorId_TextfieldSelectionBackgroundFocused from explicit colors (gfx::kGoogleBlue200 and gfx::kGoogleBlue800 ) to fall back onto kColorId_LabelTextSelectionBackgroundFocused. https://source.chromium.org/chromium/chromium/src/+/76f9ef872febca7e3630db31c699ad2c2ec4e7a5 commit 76f9ef872febca7e3630db31c699ad2c2ec4e7a5 Author: Peter Kasting <[email protected]> Date: Mon Feb 22 17:56:22 2021 +0000 Convert existing color definitions to more canonical forms. This defines as many colors as possible in terms of a small number of core colors. The primary benefit of this is to remove most dark mode color definitions (which will now be automatically correct). It also makes some relationships clearer. No behavior change intended (yet). Bug: none This change made kColorId_LabelTextSelectionBackgroundFocused fall back to AlphaBlend(kColorId_ProminentButtonColor, kColorId_WindowBackground, gfx::kGoogleGreyAlpha500) We redefine kColorId_ProminentButtonColor as kBraveColorBrand = RGB(0xfb, 0x54, 0x2b). https://source.chromium.org/chromium/chromium/src/+/c042fff0a7823aa4ebb0494d5b094f67f15aa4b3 commit c042fff0a7823aa4ebb0494d5b094f67f15aa4b3 Author: Peter Kasting <[email protected]> Date: Wed Mar 24 21:10:08 2021 +0000 Tweak existing systematized colors. Primarily, this adjusts menus, tables, trees, and textfields to all use the same blue to represent a selected item (and that blue now matches the focus ring). Bug: 1061127
Desktop NTP: background is clickable when it is a branded wallpaper
Fix "verify wallet" button on tip dialog rewards onboarding
Fixes omnibox text selection color.
remove CallJavascriptFunctionUnsafe from brave://adblock webui
fix brave/brave-browser#15605 ticker prices raw data from crypto.com could be int or double.
…s-ui Fix unsafe javascript calls in brave://rewards
Fixed crypto.com widget shows invalid price
Adds event emitter to window.ethereum object
Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9. - [Release notes](https://github.com/npm/hosted-git-info/releases) - [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md) - [Commits](npm/hosted-git-info@v2.8.8...v2.8.9) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Implement custom ad notification field trials
spylogsster
force-pushed
the
import-p2p-keys
branch
3 times, most recently
from
64a3012
to
39e7c42
Compare
spylogsster
force-pushed
the
import-p2p-keys
branch
2 times, most recently
from
9eb820f
to
e45207b
Compare
Removed File/Text/Directory import classes. Use base class instead, moved blob creation to network utilities
spylogsster
force-pushed
the
import-p2p-keys
branch
from
e45207b
to
1072b1e
Compare
spylogsster
requested review from
jumde and
zenparsing
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First (Import) part of brave/brave-browser#15566
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: