Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crypto.com widget displays wrong price #15605

Closed
simonhong opened this issue May 4, 2021 · 2 comments · Fixed by brave/brave-core#8691
Closed

Crypto.com widget displays wrong price #15605

simonhong opened this issue May 4, 2021 · 2 comments · Fixed by brave/brave-core#8691
Assignees
@simonhong
Labels
feature/widgets OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.25.x - Release

Comments

@simonhong
Copy link
Member

simonhong commented May 4, 2021 •
edited
Loading

User reported that VeChain price is invalid ($0).
image
https://www.reddit.com/r/brave_browser/comments/n3w85h/vechain_price_always_reads_000_on_dashboard/
@simonhong simonhong self-assigned this May 4, 2021
@simonhong simonhong mentioned this issue May 4, 2021
Merged
24 tasks
@stephendonner stephendonner changed the title Crypto.dom widget displays wrong price Crypto.com widget displays wrong price May 4, 2021
simonhong added a commit to brave/brave-core that referenced this issue May 5, 2021
@simonhong
Fixed crypto.com widget shows invalid price
ee26f10 
fix brave/brave-browser#15605

ticker prices raw data from crypto.com could be int or double.
simonhong added a commit to brave/brave-core that referenced this issue May 11, 2021
@simonhong
Fixed crypto.com widget shows invalid price
0fde59c 
fix brave/brave-browser#15605

ticker prices raw data from crypto.com could be int or double.
@simonhong simonhong added this to the 1.26.x - Nightly milestone May 11, 2021
@brave-builds brave-builds mentioned this issue May 11, 2021
Merged
7 tasks
@srirambv
Copy link
Contributor

Requires a new Beta Build for testing as the PR merged after the last beta build

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.25.62 Chromium: 90.0.4430.212 (Official Build) beta (64-bit)
Revision e3cd97fc771b893b7fd1879196d1215b622c2bed-refs/branch-heads/4430@{#1429}
OS Linux
  • Verified token value is shown on both list and details view
image image

Verification passed on

Brave 1.25.62 Chromium: 90.0.4430.212 (Official Build) beta (64-bit)
Revision e3cd97fc771b893b7fd1879196d1215b622c2bed-refs/branch-heads/4430@{#1429}
OS Windows 10 OS Version 2009 (Build 19042.985)
  • Verified token value is shown on both list and details view
image image

Verification passed on

Brave 1.25.62 Chromium: 90.0.4430.212 (Official Build) beta (x86_64)
Revision e3cd97fc771b893b7fd1879196d1215b622c2bed-refs/branch-heads/4430@{#1429}
OS macOS Version 10.15.7 (Build 19H114)
  • Verified token value is shown on both list and details view
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
feature/widgets OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.25.x - Release
Development

Successfully merging a pull request may close this issue.

Fixed crypto.com widget shows invalid price brave/brave-core
3 participants
@kjozwiak @simonhong @srirambv