Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed crypto.com widget shows invalid price (uplift to 1.25.x) #8770

Merged
merged 1 commit into from
May 13, 2021

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented May 11, 2021

Uplift of #8691
fix brave/brave-browser#15605

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team May 11, 2021 11:56
@brave-builds brave-builds self-assigned this May 11, 2021
@brave-builds brave-builds added this to the 1.25.x - Beta milestone May 11, 2021
@simonhong simonhong self-assigned this May 11, 2021
@kjozwiak
Copy link
Member

post-init failed due to audit-deps warning(s) as per https://ci.brave.com/job/pr-brave-browser-pr8691_fix_crypto_widget_bug_1.25.x-post-init/1/execution/node/144/log/. However, this is a known issue and unrelated to this specific PR.

Restarting macOS as it looks like it hit the 6hr limit and timed out as per https://ci.brave.com/job/pr-brave-browser-pr8691_fix_crypto_widget_bug_1.25.x-macos/1/console.

13:51:40  [545/553] STAMP obj/chrome/chrome_dump_syms.stamp
13:51:40  Cannot contact mac-mini2-ky: java.lang.InterruptedException
Calling Pipeline was cancelled
14:00:20  Sending interrupt signal to process

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.25.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #8691 (comment).

@kjozwiak kjozwiak merged commit 436572f into 1.25.x May 13, 2021
@kjozwiak kjozwiak deleted the pr8691_fix_crypto_widget_bug_1.25.x branch May 13, 2021 18:12
tmancey added a commit that referenced this pull request Mar 30, 2023
Send the segment of the chosen ad in the payload as part of Brave Ads confirmation calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants