Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed crypto.com widget shows invalid price #8691

Merged
merged 1 commit into from
May 11, 2021
Merged

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented May 4, 2021

fix brave/brave-browser#15605

ticker prices/ raw number data from crypto.com could be int or double.

Screen Shot 2021-05-04 at 9 47 05 AM

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Activate crypto.com widget in NTP
  2. Click View crypto.com markets
  3. Check VeChain price is not 0$

@simonhong simonhong requested a review from petemill May 4, 2021 01:00
@simonhong simonhong self-assigned this May 4, 2021
@simonhong simonhong requested a review from petemill May 4, 2021 10:55
@simonhong simonhong force-pushed the fix_crypto_widget_bug branch from 2034bb4 to ee26f10 Compare May 5, 2021 22:50
@simonhong
Copy link
Member Author

Kindly ping @petemill :)

Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

fix brave/brave-browser#15605

ticker prices raw data from crypto.com could be int or double.
@simonhong simonhong force-pushed the fix_crypto_widget_bug branch from ee26f10 to 0fde59c Compare May 11, 2021 06:03
@simonhong
Copy link
Member Author

Merged because only unrelated browser test was failed - AdBlockServiceTest

@simonhong simonhong merged commit 35cffb9 into master May 11, 2021
@simonhong simonhong deleted the fix_crypto_widget_bug branch May 11, 2021 11:55
@simonhong simonhong added this to the 1.26.x - Nightly milestone May 11, 2021
brave-builds pushed a commit that referenced this pull request May 11, 2021
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.26.18 Chromium: 91.0.4472.38 (Official Build) nightly (64-bit)
Revision 8155e7afab5d695cf0e028f4d77203287523cda9-refs/branch-heads/4472_35@{#6}
OS Linux
  • Verified VET token shows correct market value on both details view and token list view
image image

kylehickinson pushed a commit that referenced this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crypto.com widget displays wrong price
3 participants