Fixes omnibox text selection color. #8749
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#15690
Due to the cr91 upstream change below the omnibox selection color is
now the same color as the focus ring of the omnibox. Since we override
the focus ring to be our brand color, the selection is now also the
brand color, which we don't want.
This fix reverts the omnibox selection color to what it was in cr90
(kGoogleBlue200 for Light theme, kGoogleBlue800 for Dark).
Also, see a follow up issue brave/brave-browser#15732
Chromium changes:
This change redefined kColorId_TextfieldSelectionBackgroundFocused from
explicit colors (gfx::kGoogleBlue200 and gfx::kGoogleBlue800 ) to fall
back onto kColorId_LabelTextSelectionBackgroundFocused.
https://source.chromium.org/chromium/chromium/src/+/76f9ef872febca7e3630db31c699ad2c2ec4e7a5
commit 76f9ef872febca7e3630db31c699ad2c2ec4e7a5
Author: Peter Kasting [email protected]
Date: Mon Feb 22 17:56:22 2021 +0000
This change made kColorId_LabelTextSelectionBackgroundFocused fall back to
AlphaBlend(kColorId_ProminentButtonColor, kColorId_WindowBackground, gfx::kGoogleGreyAlpha500)
We redefine kColorId_ProminentButtonColor as kBraveColorBrand = RGB(0xfb, 0x54, 0x2b).
https://source.chromium.org/chromium/chromium/src/+/c042fff0a7823aa4ebb0494d5b094f67f15aa4b3
commit c042fff0a7823aa4ebb0494d5b094f67f15aa4b3
Author: Peter Kasting [email protected]
Date: Wed Mar 24 21:10:08 2021 +0000
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: