New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RM-55-remove-upper-bound-error-on-ratcheting-tests #212

Merged

ryantimjohn merged 2 commits into master from RM-55-remove-upper-bound-error-on-ratcheting-tests

Feb 17, 2023

Contributor

ryantimjohn commented Feb 16, 2023

No description provided.

ryantimjohn commented

View reviewed changes

setup.py Outdated Show resolved Hide resolved

ryantimjohn commented

View reviewed changes

setup.py Outdated Show resolved Hide resolved

ryantimjohn commented

View reviewed changes

setup.py Show resolved Hide resolved

ryantimjohn commented

View reviewed changes

setup.py Outdated Show resolved Hide resolved

ryantimjohn commented

View reviewed changes

setup.py Show resolved Hide resolved

ryantimjohn added 2 commits

February 16, 2023 15:09


          RM-55 update to warn when below high water mark

568320f

RM-55 update to warn when below high water mark

RM-55 apply autopep8

RM-55 shorten line

Revert "RM-55 test lowering mypy high water mark"

This reverts commit 099e56c.


          RM-55 increase bigfile watermark

b163422

ryantimjohn force-pushed the RM-55-remove-upper-bound-error-on-ratcheting-tests branch from 0cfe22e to b163422 Compare

February 16, 2023 20:09

ryantimjohn requested a review from Brunope

February 16, 2023 20:17

ryantimjohn marked this pull request as ready for review

February 16, 2023 20:17

Contributor Author

ryantimjohn commented Feb 16, 2023

@Brunope I tested these changes both by artificially lowering a high water mark and by testing against this branch:
#207

Both worked! Yay!

ryantimjohn mentioned this pull request

Bump cryptography from 39.0.0 to 39.0.1 in /docs/source #209

Merged

Brunope approved these changes

View reviewed changes

Collaborator

Brunope left a comment

Seems good. Realistically are we ever gonna see these warnings if it just runs on the builds in automation? Maybe as a once-per-release kind of thing we can check and manually update the coverage?

Contributor Author

ryantimjohn commented Feb 17, 2023

Seems good. Realistically are we ever gonna see these warnings if it just runs on the builds in automation? Maybe as a once-per-release kind of thing we can check and manually update the coverage?

I think we're never going to see these warnings, you're right.

I also agree it's a good idea to update things at least once per release!

ryantimjohn merged commit 9270417 into master

ryantimjohn deleted the RM-55-remove-upper-bound-error-on-ratcheting-tests branch

February 17, 2023 15:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet