Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RM-55-remove-upper-bound-error-on-ratcheting-tests #212

Merged
merged 2 commits into from
Feb 17, 2023
Merged

RM-55-remove-upper-bound-error-on-ratcheting-tests #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
568320f
RM-55 update to warn when below high water mark
ryantimjohn Feb 16, 2023
b163422
RM-55 increase bigfile watermark
ryantimjohn Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion metrics/bigfiles_high_water_mark
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1131
1132
7 changes: 4 additions & 3 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
from distutils.cmd import Command
import os.path
import sys
import warnings
ryantimjohn marked this conversation as resolved.
Show resolved Hide resolved
ryantimjohn marked this conversation as resolved.
Show resolved Hide resolved

__version__: Optional[str] = None
# Read in and set version variable without the overhead/requirements
Expand Down Expand Up @@ -66,9 +67,9 @@ def run(self) -> None:
f"{self.type_of_coverage} coverage used to be {high_water_mark}; "
f"down to {new_coverage}%. Fix by viewing '{self.coverage_url}'")
elif new_coverage > high_water_mark:
with open(self.coverage_file, 'w') as f:
f.write(str(new_coverage))
print(f"Just ratcheted coverage up to {new_coverage}%")
warnings.warn(
f"WARNING: Your current coverage is higher than current high watermark.\n"
f"Consider increasing high watermark in {self.coverage_file} to {new_coverage}.")
else:
print(f"Code coverage steady at {new_coverage}%")

Expand Down