RM-36 bump tenacity version

[ryantimjohn]

No description provided.

[ryantimjohn]

@Brunope, seems like this just worked.

[Brunope]

Have you tested this specifically with airflow >= 2.2.2, since that was the reason for this upgrade? The setup.py still says ">=2.0". If you have, looks good!

[ryantimjohn]

Yep! Will chat in our call today just to make sure I understand @archetypalsxe 's original ticket!

[ryantimjohn]

Related to #197

[ryantimjohn]

Okay... this is dumb. So, the coverage is different between different versions of python with this particular version of Airflow. 😠

Otherwise this passes.

I'm going to revert to >=2.0; if this ever comes up again, we'd have to update this class to be able to handle ranges:

records-mover/setup.py

Lines 39 to 73 in 9167f38

	class CoverageRatchetCommand(Command):
	description = 'Run coverage ratchet'
	user_options = [] # type: ignore
	coverage_file: str
	coverage_source_file: str
	coverage_url: str
	type_of_coverage: str
	def finalize_options(self) -> None:
	pass
	def run(self) -> None:
	"""Run command."""
	import xml.etree.ElementTree as ET
	tree = ET.parse(self.coverage_source_file)
	new_coverage = Decimal(tree.getroot().attrib["line-rate"]) * 100
	if not os.path.exists(self.coverage_file):
	with open(self.coverage_file, 'w') as f:
	f.write('0')
	with open(self.coverage_file, 'r') as f:
	high_water_mark = Decimal(f.read())
	if new_coverage < high_water_mark:
	raise Exception(
	f"{self.type_of_coverage} coverage used to be {high_water_mark}; "
	f"down to {new_coverage}%. Fix by viewing '{self.coverage_url}'")
	elif new_coverage > high_water_mark:
	with open(self.coverage_file, 'w') as f:
	f.write(str(new_coverage))
	print(f"Just ratcheted coverage up to {new_coverage}%")
	else:
	print(f"Code coverage steady at {new_coverage}%")

Or find a different way to handle ratcheting and all that which didn't rely on development in-house.

[Brunope]

I'm pretty annoyed by the ratchet coverage tests too, see this PR #209 where changing a version from 39.0.0 to 39.0.1 breaks the coverage test.