Skip to content

Commit

Permalink
Merge pull request #212 from bluelabsio/RM-55-remove-upper-bound-erro…
Browse files Browse the repository at this point in the history
…r-on-ratcheting-tests

RM-55-remove-upper-bound-error-on-ratcheting-tests
  • Loading branch information
ryantimjohn authored Feb 17, 2023
2 parents 9167f38 + b163422 commit 9270417
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion metrics/bigfiles_high_water_mark
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1131
1132
7 changes: 4 additions & 3 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
from distutils.cmd import Command
import os.path
import sys
import warnings

__version__: Optional[str] = None
# Read in and set version variable without the overhead/requirements
Expand Down Expand Up @@ -66,9 +67,9 @@ def run(self) -> None:
f"{self.type_of_coverage} coverage used to be {high_water_mark}; "
f"down to {new_coverage}%. Fix by viewing '{self.coverage_url}'")
elif new_coverage > high_water_mark:
with open(self.coverage_file, 'w') as f:
f.write(str(new_coverage))
print(f"Just ratcheted coverage up to {new_coverage}%")
warnings.warn(
f"WARNING: Your current coverage is higher than current high watermark.\n"
f"Consider increasing high watermark in {self.coverage_file} to {new_coverage}.")
else:
print(f"Code coverage steady at {new_coverage}%")

Expand Down

0 comments on commit 9270417

Please sign in to comment.