feat: changing auth over to cookies #3357

YazeedLoonat · 2023-03-15T15:57:47Z

Pull Request Template

Issue Overview

This PR addresses #issue

This change addresses the issue in full

Description

This changes us over from auth bearer tokens to auth via cookies

doing so required us to create a pseudo-proxy by way of nextjs's api. So now all requests to the backend stop by the proxy first so cookies can be properly attached

How Can This Be Tested/Reviewed?

The best way to test this is to use the stood up environments:
https://bloom-partners-orm.netlify.app/sign-in
and
https://bloom-core-orm.netlify.app/

testers should verify that basically all backend endpoints work correctly. This would include:

testing the flow of creating -> editing -> viewing details for -> viewing in public site for listings

testing the flow of creating -> editing -> viewing details for -> logging in as a user on both the public and parter site

testing the flow of applying for a listing on both the partner and public site

Checklist:

Reviewer Notes:

Steps to review a PR:

Read and understand the issue, and ensure the author has added QA notes
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

This reverts commit 840b4a1.

This reverts commit 9f13a5a.

This reverts commit 8acbfbe.

* 2250/auth cookie (#2964) Co-authored-by: Lint Action <[email protected]> Co-authored-by: Sean Albert <[email protected]> Co-authored-by: Yazeed Loonat <[email protected]>

…date-2

netlify · 2023-03-15T15:57:57Z

✅ Deploy Preview for bloom-partners-orm ready!

Name	Link
🔨 Latest commit	`41975f3`
🔍 Latest deploy log	https://app.netlify.com/sites/bloom-partners-orm/deploys/642d983098c53d000800d98d
😎 Deploy Preview	https://deploy-preview-3357--bloom-partners-orm.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify · 2023-03-15T15:57:59Z

✅ Deploy Preview for bloom-core-orm ready!

Name	Link
🔨 Latest commit	`41975f3`
🔍 Latest deploy log	https://app.netlify.com/sites/bloom-core-orm/deploys/642d9830ca042400084d2740
😎 Deploy Preview	https://deploy-preview-3357--bloom-core-orm.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify · 2023-03-15T16:00:25Z

✅ Deploy Preview for bloom-exygy-dev ready!

Name	Link
🔨 Latest commit	`41975f3`
🔍 Latest deploy log	https://app.netlify.com/sites/bloom-exygy-dev/deploys/642d98306572f70008455207
😎 Deploy Preview	https://deploy-preview-3357--bloom-exygy-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

emilyjablonski · 2023-03-15T17:31:57Z

Will need to take a look at the broken build 👀

ludtkemorgan

Functionally it all looks good, just minor comments. Thanks for sticking to this big feature!

backend/core/src/auth/passport-strategies/jwt.strategy.ts

docs/Authentication.md

sites/public/src/pages/api/adapter/[...backendUrl].ts

sites/partners/cypress/integration/07-jurisdictional-admin-user-management.spec.ts

emilyjablonski · 2023-04-03T18:51:22Z

One more poke about the dedup 🐧

package-lock.json

YazeedLoonat · 2023-04-05T16:14:21Z

Hey @emilyjablonski this should be ready for you to review again when you get a chance

emilyjablonski

Cookies: a critical part of a complete breakfast!

* fix: user export fixes (bloom-housing#3371) * fix: user export fixes * fix: update error message alert * chore(release): version - @bloom-housing/[email protected] * feat: upgrade react to 18 (bloom-housing#3360) * feat: upgrade react to 18 * feat: upgrade cypress to 12 for public * feat: upgrade cypress for partners * fix: update configs * fix: update partner cypress tests * fix: review comments * fix: fix flaky cypress test * chore(release): version - @bloom-housing/[email protected] - @bloom-housing/[email protected] - @bloom-housing/[email protected] - @bloom-housing/[email protected] * fix: program/preference keys length uncap (bloom-housing#3376) * fix: program/preference keys length uncap * fix: updates per pr comments * chore(release): version - @bloom-housing/[email protected] - @bloom-housing/[email protected] - @bloom-housing/[email protected] - @bloom-housing/[email protected] * feat: upgrade nextjs to 13 (bloom-housing#3375) * feat: upgrade nextjs to 13 * fix: attempt to get cypress test working * chore(release): version - @bloom-housing/[email protected] - @bloom-housing/[email protected] * feat: changing auth over to cookies (bloom-housing#3357) * fix: resolves issues around markedAsDuplicate (bloom-housing#3373) * chore(release): version - @bloom-housing/[email protected] - @bloom-housing/[email protected] - @bloom-housing/[email protected] - @bloom-housing/[email protected] * fix: react type errors (bloom-housing#3382) * chore(release): version - @bloom-housing/[email protected] - @bloom-housing/[email protected] - @bloom-housing/[email protected] * refactor: add cloudinary fxn to partners (bloom-housing#3393) * fix: remove max length from extra data app fields (bloom-housing#3394) * refactor: uptake seeds FormErrorMessage (bloom-housing#3369) * fix: type fix for token * fix: lock file and hydration fixes * fix: add startDate to open house submit event (bloom-housing#3399) * fix: add three new fields to base view (bloom-housing#3406) * feat: removing sensative info from leasing agent (bloom-housing#3409) * feat: removing sensative info from leasing agent * fix: adding swagger changes * fix: updates for tests * chore(deps): bump cookiejar from 2.1.2 to 2.1.4 (bloom-housing#3295) Bumps [cookiejar](https://github.com/bmeck/node-cookiejar) from 2.1.2 to 2.1.4. - [Release notes](https://github.com/bmeck/node-cookiejar/releases) - [Commits](https://github.com/bmeck/node-cookiejar/commits) --- updated-dependencies: - dependency-name: cookiejar dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: updates around cookies (bloom-housing#3405) * fix: updates around cookies * fix: creating new migration for token -> code --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: github.context.workflow <[email protected]> Co-authored-by: Yazeed Loonat <[email protected]> Co-authored-by: Emily Jablonski <[email protected]> Co-authored-by: Krzysztof Zięcina <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Chris Casto <[email protected]>

* fix: uptake latest uic Modal, ActionBlock, FormCard breaking changes (bloom-housing#3358) * feat: upgrade react to 18 (bloom-housing#3360) * feat: upgrade nextjs to 13 (bloom-housing#3375) * feat: upgrade nextjs to 13 * fix: attempt to get cypress test working * feat: changing auth over to cookies (bloom-housing#3357) * fix: resolves issues around markedAsDuplicate (bloom-housing#3373) * fix: react type errors (bloom-housing#3382) * refactor: add cloudinary fxn to partners (bloom-housing#3393) * refactor: uptake seeds FormErrorMessage (bloom-housing#3369) * fix: add startDate to open house submit event (bloom-housing#3399) * fix: add three new fields to base view (bloom-housing#3406) * feat: removing sensative info from leasing agent (bloom-housing#3409) * feat: removing sensative info from leasing agent * fix: adding swagger changes * fix: updates for tests * chore(deps): bump cookiejar from 2.1.2 to 2.1.4 (bloom-housing#3295) Bumps [cookiejar](https://github.com/bmeck/node-cookiejar) from 2.1.2 to 2.1.4. - [Release notes](https://github.com/bmeck/node-cookiejar/releases) - [Commits](https://github.com/bmeck/node-cookiejar/commits) --- updated-dependencies: - dependency-name: cookiejar dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: updates around cookies (bloom-housing#3405) * fix: updates around cookies * fix: creating new migration for token -> code * fix: Searching on the applications table causes the page to crash (bloom-housing#3408) * fix: pass proper value to to_tsquery function * fix: search applications using ILIKE * fix: change where to orWhere * feat: add application search by confirmation code * updates proxy to support access control allow list (bloom-housing#3407) * feat: updates proxy to support access control allow list * fix: remove downstream access-control-allow-origin * fix: update readme for m1 * fix: move purge call to the backend * fix: test fix and add await * fix: moving cache purge to helper --------- Co-authored-by: Morgan Ludtke <[email protected]> Co-authored-by: Yazeed Loonat <[email protected]> * fix: escape quote in translation update * fix: add translation for 64 characters error (bloom-housing#3423) * fix: downgrade version of nest axios (bloom-housing#3419) * fix: now removes criteria file if a url is input (bloom-housing#3421) * fix: remove check in test not applicable for hba * fix: update ui-c to latest version (bloom-housing#3420) * fix: update application test * feat: 3291/listing export take 2 (bloom-housing#3424) * fix: functional frontend * fix: hooks and service updates * fix: hitting service file * fix: wip config work * fix: wip config 2 * fix: completed query updates * fix: complete column naming and basic formatting * fix: clean up formatting * fix: wip testing debugging * fix: functional unit tests * fix: cypress tests + formatting * fix: unadded test changes * fix: internal csv testing * fix: exporter test fix * fix: more detailed csv checks * fix: testing + formatting tweaks * fix: exporter testing improvements * fix: updates per pr feedback * fix: match config pattern * fix: add close status option * fix: reset netlify testing * fix: final cleanup * fix: rent type formatting * fix: remove console log * fix: missing state data (bloom-housing#3450) * feat: adding knownError flag * feat: adding knownError flag * fix: partners highlight field on backend error (bloom-housing#3448) * fix: partners highlight field on backend error * fix: community type and disableUnitsAccordion fix * fix: unit type fix for partial units * fix: review comment addressed * fix: phone number fix --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Yazeed Loonat <[email protected]> Co-authored-by: Emily Jablonski <[email protected]> Co-authored-by: Krzysztof Zięcina <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sean Albert <[email protected]> Co-authored-by: ColinBuyck <[email protected]>

ludtkemorgan and others added 21 commits February 27, 2023 16:53

feat: upgrade to node 19 and next 12

7aca4b3

fix: add netlify plugin

1f8ba85

fix: add netlify plugin partners

9caaebc

fix: remove netlify plugins

840b4a1

fix: add netlify plugin to toml

78b189f

Revert "fix: remove netlify plugins"

0dac79f

This reverts commit 840b4a1.

fix: switch to node 16

8acbfbe

fix: update all places referencing node

9f13a5a

Revert "fix: update all places referencing node"

7587cc4

This reverts commit 9f13a5a.

Revert "fix: switch to node 16"

82e94d8

This reverts commit 8acbfbe.

fix: re-installed with 18

f7bd202

feat: switching to auth cookies

1e47846

* 2250/auth cookie (#2964) Co-authored-by: Lint Action <[email protected]> Co-authored-by: Sean Albert <[email protected]> Co-authored-by: Yazeed Loonat <[email protected]>

fix: adding package

92ca915

fix: updates for api

d34ec24

Merge remote-tracking branch 'upstream/3317/node' into 2250/cookie-up…

e10973a

…date-2

fix: samesite none on hosted envs

adc6661

fix: testing some stuff

076be08

fix: sign out fix (maybe)

bddf1a5

fix: putting back change

60e7a80

Merge remote-tracking branch 'upstream/main' into 2250/cookie-update-2

4c7d7be

feat: updates for cookies

01ad176

YazeedLoonat added the 2 reviews needed Requires 2 more review before ready to merge label Mar 15, 2023

YazeedLoonat requested review from ludtkemorgan, ColinBuyck and emilyjablonski March 15, 2023 15:57

emilyjablonski added the needs changes The author must make changes and then re-request review before merging label Mar 15, 2023

ludtkemorgan approved these changes Mar 30, 2023

View reviewed changes

emilyjablonski added 1 review needed Requires 1 more review before ready to merge and removed 2 reviews needed Requires 2 more review before ready to merge labels Mar 30, 2023

YazeedLoonat added 2 commits March 31, 2023 16:00

fix: removing unneeded sign out

ec94007

fix: updates per pr notes

73e29b0

YazeedLoonat temporarily deployed to bloom-backend-orm April 1, 2023 00:04 Inactive

Merge remote-tracking branch 'origin/main' into 2250/cookie-update-2

7f4c312

YazeedLoonat temporarily deployed to bloom-backend-orm April 3, 2023 15:57 Inactive

fix: updates for tests

244fdda

YazeedLoonat temporarily deployed to bloom-backend-orm April 3, 2023 19:29 Inactive

YazeedLoonat added 2 commits April 3, 2023 14:12

fix: dedupe

08dd992

Merge remote-tracking branch 'origin/main' into 2250/cookie-update-2

594474f

YazeedLoonat temporarily deployed to bloom-backend-orm April 3, 2023 21:30 Inactive

emilyjablonski reviewed Apr 3, 2023

View reviewed changes

package-lock.json Outdated Show resolved Hide resolved

fix: putting things back

41975f3

YazeedLoonat temporarily deployed to bloom-backend-orm April 5, 2023 15:48 Inactive

YazeedLoonat mentioned this pull request Apr 5, 2023

Dedupe nextjs adapter #3378

Open

YazeedLoonat requested a review from emilyjablonski April 5, 2023 16:14

emilyjablonski approved these changes Apr 6, 2023

View reviewed changes

emilyjablonski added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels Apr 6, 2023

YazeedLoonat merged commit cd03929 into main Apr 7, 2023

ludtkemorgan pushed a commit to housingbayarea/bloom that referenced this pull request May 2, 2023

feat: changing auth over to cookies (bloom-housing#3357)

5eedba1

ludtkemorgan mentioned this pull request May 5, 2023

Release/2023 05 02 housingbayarea/bloom#612

Merged

ludtkemorgan pushed a commit to housingbayarea/bloom that referenced this pull request May 9, 2023

feat: changing auth over to cookies (bloom-housing#3357)

0c1f08a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: changing auth over to cookies #3357

feat: changing auth over to cookies #3357

YazeedLoonat commented Mar 15, 2023

netlify bot commented Mar 15, 2023 •

edited

Loading

netlify bot commented Mar 15, 2023 •

edited

Loading

netlify bot commented Mar 15, 2023 •

edited

Loading

emilyjablonski commented Mar 15, 2023

ludtkemorgan left a comment

emilyjablonski commented Apr 3, 2023

YazeedLoonat commented Apr 5, 2023

emilyjablonski left a comment

feat: changing auth over to cookies #3357

feat: changing auth over to cookies #3357

Conversation

YazeedLoonat commented Mar 15, 2023

Pull Request Template

Issue Overview

Description

How Can This Be Tested/Reviewed?

Checklist:

Reviewer Notes:

On Merge:

netlify bot commented Mar 15, 2023 • edited Loading

✅ Deploy Preview for bloom-partners-orm ready!

netlify bot commented Mar 15, 2023 • edited Loading

✅ Deploy Preview for bloom-core-orm ready!

netlify bot commented Mar 15, 2023 • edited Loading

✅ Deploy Preview for bloom-exygy-dev ready!

emilyjablonski commented Mar 15, 2023

ludtkemorgan left a comment

Choose a reason for hiding this comment

emilyjablonski commented Apr 3, 2023

YazeedLoonat commented Apr 5, 2023

emilyjablonski left a comment

Choose a reason for hiding this comment

netlify bot commented Mar 15, 2023 •

edited

Loading

netlify bot commented Mar 15, 2023 •

edited

Loading

netlify bot commented Mar 15, 2023 •

edited

Loading