Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: user export fixes #3371

Merged
merged 2 commits into from
Mar 31, 2023
Merged

fix: user export fixes #3371

merged 2 commits into from
Mar 31, 2023

Conversation

ludtkemorgan
Copy link
Collaborator

Pull Request Template

Issue Overview

This PR addresses #3282, CityOfDetroit#1594

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

This carries over all of the fixes from the bug bash we did on Detroit's export CSV feature.
It fixes the following things:

  • Change "Export" to "Export to CSV"
  • Unify the success message location in translation file
  • Make the success toaster more determinant. (doesn't reappear randomly)
  • Make the buttons the bigger size

Unrelated to the user export it also adds the success toaster to the application export feature since we now get that functionality for free.

How Can This Be Tested/Reviewed?

Go to the users page on the partners site and click "Export to CSV". The success toaster should appear and not reappear later until you click the export button again

Checklist:

  • My code follows the style guidelines of this project
  • I have added QA notes to the issue with applicable URLs
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have run yarn generate:client and/or created a migration if I made backend changes that require them
  • I have exported any new pieces added to ui-components
  • My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
  • Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue, and ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

@ludtkemorgan ludtkemorgan added the 2 reviews needed Requires 2 more review before ready to merge label Mar 30, 2023
@ludtkemorgan ludtkemorgan requested a review from ColinBuyck March 30, 2023 14:06
@ludtkemorgan ludtkemorgan mentioned this pull request Mar 30, 2023
Merged
@netlify
Copy link

netlify bot commented Mar 30, 2023 •
edited
Loading

✅ Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit bf617b0
🔍 Latest deploy log https://app.netlify.com/sites/bloom-exygy-dev/deploys/6426112236f69800085bc181
😎 Deploy Preview https://deploy-preview-3371--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

ColinBuyck
ColinBuyck approved these changes Mar 30, 2023
View reviewed changes
Copy link
Collaborator

@ColinBuyck ColinBuyck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🖌️ only other thing I can think of is to align the error messaging with the changes
here https://github.com/CityOfDetroit/bloom/pull/1604/files

@ColinBuyck ColinBuyck added 1 review needed Requires 1 more review before ready to merge and removed 2 reviews needed Requires 2 more review before ready to merge labels Mar 30, 2023
@ludtkemorgan
Copy link
Collaborator Author

LGTM 🖌️ only other thing I can think of is to align the error messaging with the changes here https://github.com/CityOfDetroit/bloom/pull/1604/files

@ColinBuyck Thanks! this error message changes have been added

@emilyjablonski emilyjablonski added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels Mar 31, 2023
@ludtkemorgan ludtkemorgan merged commit 2068f9c into main Mar 31, 2023
ludtkemorgan added a commit to housingbayarea/bloom that referenced this pull request Mar 31, 2023
@ludtkemorgan
fix: user export fixes (bloom-housing#3371)
63dd5af 
* fix: user export fixes

* fix: update error message alert
ludtkemorgan added a commit to housingbayarea/bloom that referenced this pull request Mar 31, 2023
@ludtkemorgan
fix: user export fixes (bloom-housing#3371)
feb194c 
* fix: user export fixes

* fix: update error message alert
ludtkemorgan added a commit to housingbayarea/bloom that referenced this pull request Apr 3, 2023
@ludtkemorgan @lisunshiny @dependabot
feat: release 2023-03-27 (#604)
424c8fd 
* test: add unit tests on the ListingView component (bloom-housing#3344)

* test: add unit tests on the ListingView component

* chore: make date variables consistent

* test: remove afterEach line

* chore(deps): bump class-validator from 0.12.2 to 0.14.0 (bloom-housing#3257)

Bumps [class-validator](https://github.com/typestack/class-validator) from 0.12.2 to 0.14.0.
- [Release notes](https://github.com/typestack/class-validator/releases)
- [Changelog](https://github.com/typestack/class-validator/blob/develop/CHANGELOG.md)
- [Commits](typestack/class-validator@v0.12.2...v0.14.0)

---
updated-dependencies:
- dependency-name: class-validator
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: upgrade to node 18 and next 12 (bloom-housing#3343)

* feat: upgrade to node 19 and next 12

* fix: add netlify plugin

* fix: add netlify plugin partners

* fix: remove netlify plugins

* fix: add netlify plugin to toml

* Revert "fix: remove netlify plugins"

This reverts commit 840b4a1.

* fix: switch to node 16

* fix: update all places referencing node

* Revert "fix: update all places referencing node"

This reverts commit 9f13a5a.

* Revert "fix: switch to node 16"

This reverts commit 8acbfbe.

* fix: re-installed with 18

* feat: add user csv export (bloom-housing#3341)

* fix: uptake latest uic Modal, ActionBlock, FormCard breaking changes (bloom-housing#3358)

* feat: add shared bathroom option  (bloom-housing#3362)

* fix: add imports to calm tests

* Revert "fix: uptake latest uic Modal, ActionBlock, FormCard breaking changes (bloom-housing#3358)"

This reverts commit b1153f0.

* fix: user export fixes (bloom-housing#3371)

* fix: user export fixes

* fix: update error message alert

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Liann Sun <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
lisunshiny pushed a commit to metrotranscom/doorway that referenced this pull request Apr 13, 2023
@ludtkemorgan @lisunshiny
fix: user export fixes (bloom-housing#3371)
1bf8a9f 
* fix: user export fixes

* fix: update error message alert
chriscasto added a commit to metrotranscom/doorway that referenced this pull request Apr 20, 2023
@ludtkemorgan @YazeedLoonat
@emilyjablonski @KrissDrawing @dependabot @chriscasto
Merge Bloom Core (#47)
06cd4e8 
* fix: user export fixes (bloom-housing#3371)

* fix: user export fixes

* fix: update error message alert

* chore(release): version

 - @bloom-housing/[email protected]

* feat: upgrade react to 18 (bloom-housing#3360)

* feat: upgrade react to 18

* feat: upgrade cypress to 12 for public

* feat: upgrade cypress for partners

* fix: update configs

* fix: update partner cypress tests

* fix: review comments

* fix: fix flaky cypress test

* chore(release): version

 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]

* fix: program/preference keys length uncap (bloom-housing#3376)

* fix: program/preference keys length uncap

* fix: updates per pr comments

* chore(release): version

 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]

* feat: upgrade nextjs to 13 (bloom-housing#3375)

* feat: upgrade nextjs to 13

* fix: attempt to get cypress test working

* chore(release): version

 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]

* feat: changing auth over to cookies (bloom-housing#3357)

* fix: resolves issues around markedAsDuplicate (bloom-housing#3373)

* chore(release): version

 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]

* fix: react type errors (bloom-housing#3382)

* chore(release): version

 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]

* refactor: add cloudinary fxn to partners (bloom-housing#3393)

* fix: remove max length from extra data app fields (bloom-housing#3394)

* refactor: uptake seeds FormErrorMessage (bloom-housing#3369)

* fix: type fix for token

* fix: lock file and hydration fixes

* fix: add startDate to open house submit event (bloom-housing#3399)

* fix: add three new fields to base view (bloom-housing#3406)

* feat: removing sensative info from leasing agent (bloom-housing#3409)

* feat: removing sensative info from leasing agent

* fix: adding swagger changes

* fix: updates for tests

* chore(deps): bump cookiejar from 2.1.2 to 2.1.4 (bloom-housing#3295)

Bumps [cookiejar](https://github.com/bmeck/node-cookiejar) from 2.1.2 to 2.1.4.
- [Release notes](https://github.com/bmeck/node-cookiejar/releases)
- [Commits](https://github.com/bmeck/node-cookiejar/commits)

---
updated-dependencies:
- dependency-name: cookiejar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: updates around cookies (bloom-housing#3405)

* fix: updates around cookies

* fix: creating new migration for token -> code

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: github.context.workflow <[email protected]>
Co-authored-by: Yazeed Loonat <[email protected]>
Co-authored-by: Emily Jablonski <[email protected]>
Co-authored-by: Krzysztof Zięcina <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Chris Casto <[email protected]>
ifranch pushed a commit to metrotranscom/doorway that referenced this pull request Apr 21, 2023
@ludtkemorgan @YazeedLoonat
@emilyjablonski @KrissDrawing @dependabot @chriscasto
Merge Bloom Core (#47)
68ec4e9 
* fix: user export fixes (bloom-housing#3371)

* fix: user export fixes

* fix: update error message alert

* chore(release): version

 - @bloom-housing/[email protected]

* feat: upgrade react to 18 (bloom-housing#3360)

* feat: upgrade react to 18

* feat: upgrade cypress to 12 for public

* feat: upgrade cypress for partners

* fix: update configs

* fix: update partner cypress tests

* fix: review comments

* fix: fix flaky cypress test

* chore(release): version

 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]

* fix: program/preference keys length uncap (bloom-housing#3376)

* fix: program/preference keys length uncap

* fix: updates per pr comments

* chore(release): version

 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]

* feat: upgrade nextjs to 13 (bloom-housing#3375)

* feat: upgrade nextjs to 13

* fix: attempt to get cypress test working

* chore(release): version

 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]

* feat: changing auth over to cookies (bloom-housing#3357)

* fix: resolves issues around markedAsDuplicate (bloom-housing#3373)

* chore(release): version

 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]

* fix: react type errors (bloom-housing#3382)

* chore(release): version

 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]

* refactor: add cloudinary fxn to partners (bloom-housing#3393)

* fix: remove max length from extra data app fields (bloom-housing#3394)

* refactor: uptake seeds FormErrorMessage (bloom-housing#3369)

* fix: type fix for token

* fix: lock file and hydration fixes

* fix: add startDate to open house submit event (bloom-housing#3399)

* fix: add three new fields to base view (bloom-housing#3406)

* feat: removing sensative info from leasing agent (bloom-housing#3409)

* feat: removing sensative info from leasing agent

* fix: adding swagger changes

* fix: updates for tests

* chore(deps): bump cookiejar from 2.1.2 to 2.1.4 (bloom-housing#3295)

Bumps [cookiejar](https://github.com/bmeck/node-cookiejar) from 2.1.2 to 2.1.4.
- [Release notes](https://github.com/bmeck/node-cookiejar/releases)
- [Commits](https://github.com/bmeck/node-cookiejar/commits)

---
updated-dependencies:
- dependency-name: cookiejar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: updates around cookies (bloom-housing#3405)

* fix: updates around cookies

* fix: creating new migration for token -> code

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: github.context.workflow <[email protected]>
Co-authored-by: Yazeed Loonat <[email protected]>
Co-authored-by: Emily Jablonski <[email protected]>
Co-authored-by: Krzysztof Zięcina <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Chris Casto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColinBuyck ColinBuyck ColinBuyck approved these changes

@emilyjablonski emilyjablonski emilyjablonski approved these changes

Assignees
No one assigned
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ludtkemorgan @ColinBuyck @emilyjablonski