Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove max length from extra data app fields #3394

Merged
merged 1 commit into from
Apr 13, 2023
Merged

fix: remove max length from extra data app fields #3394

merged 1 commit into from
Apr 13, 2023

Conversation

emilyjablonski
Copy link
Collaborator

@emilyjablonski emilyjablonski commented Apr 12, 2023 •
edited
Loading

Pull Request Template

Issue Overview

This PR addresses #606

Description

Right now on production if you have a preference with a long option name (>128 characters) that also collects an address, if you try to submit an application with that address filled out the submission fails. The form field key includes the option name + there is a max length applied on the backend. This PR removes that validator on the key.

How Can This Be Tested/Reviewed?

Adding this preference and selecting it and adding an address will cause the application submission to fail on main.
Option name: At least one member of my household was required to relocate from current Dublin residence due to demolition of dwelling or conversation of dwelling from rental to for-sale unit (1 point) and Collect the applicant address.

Checklist:

  • My code follows the style guidelines of this project
  • I have added QA notes to the issue with applicable URLs
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have run yarn generate:client and/or created a migration if I made backend changes that require them
  • My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
  • Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue, and ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

@netlify
Copy link

netlify bot commented Apr 12, 2023

✅ Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit fd96818
🔍 Latest deploy log https://app.netlify.com/sites/bloom-exygy-dev/deploys/6437092caebf870008bec9b4
😎 Deploy Preview https://deploy-preview-3394--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@emilyjablonski emilyjablonski marked this pull request as ready for review April 12, 2023 23:08
@emilyjablonski emilyjablonski added the 2 reviews needed Requires 2 more review before ready to merge label Apr 12, 2023
YazeedLoonat
YazeedLoonat approved these changes Apr 12, 2023
View reviewed changes
Copy link
Collaborator

@YazeedLoonat YazeedLoonat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YazeedLoonat YazeedLoonat added 1 review needed Requires 1 more review before ready to merge and removed 2 reviews needed Requires 2 more review before ready to merge labels Apr 12, 2023
@ludtkemorgan ludtkemorgan added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels Apr 13, 2023
@emilyjablonski emilyjablonski merged commit 5efdb17 into main Apr 13, 2023
emilyjablonski added a commit to housingbayarea/bloom that referenced this pull request Apr 13, 2023
@emilyjablonski
fix: remove max length from extra data app fields (bloom-housing#3394)
b17e909
@emilyjablonski emilyjablonski mentioned this pull request Apr 13, 2023
Merged
emilyjablonski added a commit to housingbayarea/bloom that referenced this pull request Apr 13, 2023
@emilyjablonski
fix: remove max length from extra data app fields (bloom-housing#3394) (
68a58a4 
#609)
chriscasto added a commit to metrotranscom/doorway that referenced this pull request Apr 20, 2023
@ludtkemorgan @YazeedLoonat
@emilyjablonski @KrissDrawing @dependabot @chriscasto
Merge Bloom Core (#47)
06cd4e8 
* fix: user export fixes (bloom-housing#3371)

* fix: user export fixes

* fix: update error message alert

* chore(release): version

 - @bloom-housing/[email protected]

* feat: upgrade react to 18 (bloom-housing#3360)

* feat: upgrade react to 18

* feat: upgrade cypress to 12 for public

* feat: upgrade cypress for partners

* fix: update configs

* fix: update partner cypress tests

* fix: review comments

* fix: fix flaky cypress test

* chore(release): version

 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]

* fix: program/preference keys length uncap (bloom-housing#3376)

* fix: program/preference keys length uncap

* fix: updates per pr comments

* chore(release): version

 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]

* feat: upgrade nextjs to 13 (bloom-housing#3375)

* feat: upgrade nextjs to 13

* fix: attempt to get cypress test working

* chore(release): version

 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]

* feat: changing auth over to cookies (bloom-housing#3357)

* fix: resolves issues around markedAsDuplicate (bloom-housing#3373)

* chore(release): version

 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]

* fix: react type errors (bloom-housing#3382)

* chore(release): version

 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]

* refactor: add cloudinary fxn to partners (bloom-housing#3393)

* fix: remove max length from extra data app fields (bloom-housing#3394)

* refactor: uptake seeds FormErrorMessage (bloom-housing#3369)

* fix: type fix for token

* fix: lock file and hydration fixes

* fix: add startDate to open house submit event (bloom-housing#3399)

* fix: add three new fields to base view (bloom-housing#3406)

* feat: removing sensative info from leasing agent (bloom-housing#3409)

* feat: removing sensative info from leasing agent

* fix: adding swagger changes

* fix: updates for tests

* chore(deps): bump cookiejar from 2.1.2 to 2.1.4 (bloom-housing#3295)

Bumps [cookiejar](https://github.com/bmeck/node-cookiejar) from 2.1.2 to 2.1.4.
- [Release notes](https://github.com/bmeck/node-cookiejar/releases)
- [Commits](https://github.com/bmeck/node-cookiejar/commits)

---
updated-dependencies:
- dependency-name: cookiejar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: updates around cookies (bloom-housing#3405)

* fix: updates around cookies

* fix: creating new migration for token -> code

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: github.context.workflow <[email protected]>
Co-authored-by: Yazeed Loonat <[email protected]>
Co-authored-by: Emily Jablonski <[email protected]>
Co-authored-by: Krzysztof Zięcina <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Chris Casto <[email protected]>
ifranch pushed a commit to metrotranscom/doorway that referenced this pull request Apr 21, 2023
@ludtkemorgan @YazeedLoonat
@emilyjablonski @KrissDrawing @dependabot @chriscasto
Merge Bloom Core (#47)
68ec4e9 
* fix: user export fixes (bloom-housing#3371)

* fix: user export fixes

* fix: update error message alert

* chore(release): version

 - @bloom-housing/[email protected]

* feat: upgrade react to 18 (bloom-housing#3360)

* feat: upgrade react to 18

* feat: upgrade cypress to 12 for public

* feat: upgrade cypress for partners

* fix: update configs

* fix: update partner cypress tests

* fix: review comments

* fix: fix flaky cypress test

* chore(release): version

 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]

* fix: program/preference keys length uncap (bloom-housing#3376)

* fix: program/preference keys length uncap

* fix: updates per pr comments

* chore(release): version

 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]

* feat: upgrade nextjs to 13 (bloom-housing#3375)

* feat: upgrade nextjs to 13

* fix: attempt to get cypress test working

* chore(release): version

 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]

* feat: changing auth over to cookies (bloom-housing#3357)

* fix: resolves issues around markedAsDuplicate (bloom-housing#3373)

* chore(release): version

 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]

* fix: react type errors (bloom-housing#3382)

* chore(release): version

 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]
 - @bloom-housing/[email protected]

* refactor: add cloudinary fxn to partners (bloom-housing#3393)

* fix: remove max length from extra data app fields (bloom-housing#3394)

* refactor: uptake seeds FormErrorMessage (bloom-housing#3369)

* fix: type fix for token

* fix: lock file and hydration fixes

* fix: add startDate to open house submit event (bloom-housing#3399)

* fix: add three new fields to base view (bloom-housing#3406)

* feat: removing sensative info from leasing agent (bloom-housing#3409)

* feat: removing sensative info from leasing agent

* fix: adding swagger changes

* fix: updates for tests

* chore(deps): bump cookiejar from 2.1.2 to 2.1.4 (bloom-housing#3295)

Bumps [cookiejar](https://github.com/bmeck/node-cookiejar) from 2.1.2 to 2.1.4.
- [Release notes](https://github.com/bmeck/node-cookiejar/releases)
- [Commits](https://github.com/bmeck/node-cookiejar/commits)

---
updated-dependencies:
- dependency-name: cookiejar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: updates around cookies (bloom-housing#3405)

* fix: updates around cookies

* fix: creating new migration for token -> code

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: github.context.workflow <[email protected]>
Co-authored-by: Yazeed Loonat <[email protected]>
Co-authored-by: Emily Jablonski <[email protected]>
Co-authored-by: Krzysztof Zięcina <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Chris Casto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YazeedLoonat YazeedLoonat YazeedLoonat approved these changes

@ludtkemorgan ludtkemorgan ludtkemorgan approved these changes

Assignees
No one assigned
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emilyjablonski @YazeedLoonat @ludtkemorgan