Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedupe nextjs adapter #3378

Open
YazeedLoonat opened this issue Apr 5, 2023 · 0 comments
Open

Dedupe nextjs adapter #3378

YazeedLoonat opened this issue Apr 5, 2023 · 0 comments
Labels
tech debt Long-term required changes that has been push down the road validated Legitimate bug or issue

Comments

@YazeedLoonat
Copy link
Collaborator

What is this feature or what feature is this part of?
This is a spin off of: #3357

currently we have duplicated code the [...backendUrl.ts] files on the partner and public site. This is a ticketo to dedupe this and move the code into the shared-helpers folder.

Cannot find module 'node:url' from 'node_modules/http-cookie-agent/dist/http/create_cookie_agent.js' is the error we were running into when first attempting it. Which from reading https://stackoverflow.com/questions/73303447/cannot-find-module-nodeurl-when-executing-typescript-from-webstorm seems to be a problem between jest and node's url module.
https://stackoverflow.com/questions/75508376/jest-does-not-recognize-typeerror-thrown-by-url-constructor has a few examples of this not working as well as jestjs/jest#2549 (comment) which has a possible solution which didn't work when attempted.

@YazeedLoonat YazeedLoonat added the tech debt Long-term required changes that has been push down the road label Apr 5, 2023
@emilyjablonski emilyjablonski added the validated Legitimate bug or issue label Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt Long-term required changes that has been push down the road validated Legitimate bug or issue
Projects
None yet
Development

No branches or pull requests

2 participants