Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert workflow changes #12376

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Conversation

trmartin4
Copy link
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-15126

📔 Objective

Reverts:

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@trmartin4 trmartin4 requested a review from a team as a code owner December 12, 2024 17:12
Copy link
Contributor

@withinfocus withinfocus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed.

@trmartin4 trmartin4 requested review from addisonbeck and dani-garcia and removed request for dani-garcia and addisonbeck December 12, 2024 17:14
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details43fafe1d-85b2-4282-8b75-18b5eda75c20

New Issues

Severity Issue Source File / Package Checkmarx Insight
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 357 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1356 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 853 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-browser.yml: 434 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1505 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1101 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 665 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-web.yml: 337 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-web.yml: 227 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1456 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-cli.yml: 121 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-browser.yml: 379 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-browser.yml: 478 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1012 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-browser.yml: 184 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-cli.yml: 465 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-cli.yml: 276 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 342 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 191 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-web.yml: 306 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-web.yml: 385 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build-web.yml: 132 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1543
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 194
LOW Unpinned Actions Full Length Commit SHA /build-web.yml: 316
LOW Unpinned Actions Full Length Commit SHA /build-web.yml: 395
LOW Unpinned Actions Full Length Commit SHA /build-web.yml: 137
LOW Unpinned Actions Full Length Commit SHA /build-browser.yml: 482
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1494
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1394
LOW Unpinned Actions Full Length Commit SHA /build-browser.yml: 187
LOW Unpinned Actions Full Length Commit SHA /build-cli.yml: 470
LOW Unpinned Actions Full Length Commit SHA /build-cli.yml: 281
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 889
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1138
LOW Unpinned Actions Full Length Commit SHA /build-web.yml: 236
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1049
LOW Unpinned Actions Full Length Commit SHA /build-browser.yml: 383
LOW Unpinned Actions Full Length Commit SHA /build-cli.yml: 126
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 699
LOW Unpinned Actions Full Length Commit SHA /build-browser.yml: 438
LOW Unpinned Actions Full Length Commit SHA /build-web.yml: 347
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 347
LOW Unpinned Actions Full Length Commit SHA /build-desktop.yml: 362

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.37%. Comparing base (0df7b53) to head (617c7fe).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12376   +/-   ##
=======================================
  Coverage   33.36%   33.37%           
=======================================
  Files        2908     2908           
  Lines       90978    90978           
  Branches    17325    17325           
=======================================
+ Hits        30356    30363    +7     
+ Misses      58219    58212    -7     
  Partials     2403     2403           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trmartin4 trmartin4 merged commit 7c8b9db into main Dec 12, 2024
20 checks passed
@trmartin4 trmartin4 deleted the platform/pm-15126/revert-workflow-changes branch December 12, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants