[PM-15126] Tighten scope of our client build pipelines to remove reliance on secrets #12243
+269
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New Issues
Fixed Issues
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #12243 +/- ##
==========================================
- Coverage 33.43% 33.42% -0.01%
==========================================
Files 2901 2901
Lines 90566 90566
Branches 17213 17213
==========================================
- Hits 30279 30272 -7
- Misses 57892 57899 +7
Partials 2395 2395 ☔ View full report in Codecov by Sentry. |
coroiu
force-pushed
the
PM-15126-tighten-scope-of-our-client-build-pipelines-to-remove-reliance-on-secrets
branch
from
50c5323 to
336ccf1
Compare
addisonbeck
reviewed
Dec 10, 2024
…ipelines-to-remove-reliance-on-secrets
addisonbeck
approved these changes
Dec 11, 2024
…ipelines-to-remove-reliance-on-secrets
coroiu
deleted the
PM-15126-tighten-scope-of-our-client-build-pipelines-to-remove-reliance-on-secrets
branch
trmartin4
added a commit
that referenced
this pull request
Dec 12, 2024
coroiu
added a commit
to coroiu/clients
that referenced
this pull request
Dec 13, 2024
…ance on secrets (bitwarden#12243) * feat: create copy of desktop build for PR target * chore: add temporary file to trigger ci * fix: remove check-run from regular desktop build * feat: change browser build to not use pr target * fix: skip build-safari if secret is not available * feat: skip safari build if secrets are not available * feat: let windows desktop build without secrets * fix: has_secrets not being output correctly * feat: let macos desktop build without secrets * feat: don't build browser as part of desktop * feat: change CLI to pull_request * feat: let web build without secrets * feat: tweak lint to run on PR and not just push * feat: add PR target workflows * fix: remove wip files * fix: lint on hotfix-rc branches * feat: add new workflows to CODEOWNERS (cherry picked from commit f8c33ea)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
📔 Objective
This PR changes how our CI workflows run so that they are able to run even without secrets. It also adds another another set of workflows that can be manually triggered by Bitwarden employees to build contributor PRs with full access to secrets if needed.
build-<app>.ymlworkflows now run onpull_requestinstead ofpull_request_target, this means that:build-<app>-target.ymlhave been added to let Bitwarden employees manually triggerbuild-<app>.ymlusingpull_request_targetwhich gives it access to all the secretsbuild-<app>.ymlbut with full inherited secretsHere is an example of these workflows running in a fork: coroiu#1
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes