-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[PM-15126] Tighten scope of our client build pipelines to remove reli…
…ance on secrets (#12243) * feat: create copy of desktop build for PR target * chore: add temporary file to trigger ci * fix: remove check-run from regular desktop build * feat: change browser build to not use pr target * fix: skip build-safari if secret is not available * feat: skip safari build if secrets are not available * feat: let windows desktop build without secrets * fix: has_secrets not being output correctly * feat: let macos desktop build without secrets * feat: don't build browser as part of desktop * feat: change CLI to pull_request * feat: let web build without secrets * feat: tweak lint to run on PR and not just push * feat: add PR target workflows * fix: remove wip files * fix: lint on hotfix-rc branches * feat: add new workflows to CODEOWNERS
- Loading branch information
Showing
10 changed files
with
269 additions
and
43 deletions.
There are no files selected for viewing
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| name: Build Browser on PR Target | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [opened, synchronize] | ||
| branches-ignore: | ||
| - 'l10n_master' | ||
| - 'cf-pages' | ||
| paths: | ||
| - 'apps/browser/**' | ||
| - 'libs/**' | ||
| - '*' | ||
| - '!*.md' | ||
| - '!*.txt' | ||
| workflow_call: | ||
| inputs: {} | ||
| workflow_dispatch: | ||
| inputs: | ||
| sdk_branch: | ||
| description: "Custom SDK branch" | ||
| required: false | ||
| type: string | ||
|
|
||
| defaults: | ||
| run: | ||
| shell: bash | ||
|
|
||
| jobs: | ||
| check-run: | ||
| name: Check PR run | ||
| uses: bitwarden/gh-actions/.github/workflows/check-run.yml@main | ||
|
|
||
| run-workflow: | ||
| name: Run Build Browser on PR Target | ||
| needs: check-run | ||
| if: ${{ github.event.pull_request.head.repo.full_name != github.repository }} | ||
| uses: ./.github/workflows/build-browser.yml | ||
| secrets: inherit | ||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| name: Build CLI on PR Target | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [opened, synchronize] | ||
| branches-ignore: | ||
| - 'l10n_master' | ||
| - 'cf-pages' | ||
| paths: | ||
| - 'apps/cli/**' | ||
| - 'libs/**' | ||
| - '*' | ||
| - '!*.md' | ||
| - '!*.txt' | ||
| - '.github/workflows/build-cli.yml' | ||
| - 'bitwarden_license/bit-cli/**' | ||
| workflow_dispatch: | ||
| inputs: | ||
| sdk_branch: | ||
| description: "Custom SDK branch" | ||
| required: false | ||
| type: string | ||
|
|
||
| defaults: | ||
| run: | ||
| shell: bash | ||
|
|
||
| jobs: | ||
| check-run: | ||
| name: Check PR run | ||
| uses: bitwarden/gh-actions/.github/workflows/check-run.yml@main | ||
|
|
||
| run-workflow: | ||
| name: Run Build CLI on PR Target | ||
| needs: check-run | ||
| if: ${{ github.event.pull_request.head.repo.full_name != github.repository }} | ||
| uses: ./.github/workflows/build-cli.yml | ||
| secrets: inherit | ||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| name: Build Desktop on PR Target | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [opened, synchronize] | ||
| branches-ignore: | ||
| - 'l10n_master' | ||
| - 'cf-pages' | ||
| paths: | ||
| - 'apps/desktop/**' | ||
| - 'libs/**' | ||
| - '*' | ||
| - '!*.md' | ||
| - '!*.txt' | ||
| - '.github/workflows/build-desktop.yml' | ||
| workflow_dispatch: | ||
| inputs: | ||
| sdk_branch: | ||
| description: "Custom SDK branch" | ||
| required: false | ||
| type: string | ||
|
|
||
| defaults: | ||
| run: | ||
| shell: bash | ||
|
|
||
| jobs: | ||
| check-run: | ||
| name: Check PR run | ||
| uses: bitwarden/gh-actions/.github/workflows/check-run.yml@main | ||
|
|
||
| run-workflow: | ||
| name: Run Build Desktop on PR Target | ||
| needs: check-run | ||
| if: ${{ github.event.pull_request.head.repo.full_name != github.repository }} | ||
| uses: ./.github/workflows/build-desktop.yml | ||
| secrets: inherit | ||
|
|
Oops, something went wrong.