Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: target workflows not triggering on pull_request_target #12370

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

coroiu
Copy link
Contributor

@coroiu coroiu commented Dec 12, 2024

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@coroiu coroiu requested a review from a team as a code owner December 12, 2024 12:32
@coroiu coroiu requested a review from justindbaur December 12, 2024 12:32
@coroiu coroiu enabled auto-merge (squash) December 12, 2024 12:35
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details8dbada78-a14b-4880-a239-ff5bf01a4a93

No New Or Fixed Issues Found

@coroiu coroiu merged commit 645d36f into main Dec 12, 2024
17 checks passed
@coroiu coroiu deleted the coroiu/fix-pr-target branch December 12, 2024 12:42
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.43%. Comparing base (5c345c9) to head (51201c4).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12370   +/-   ##
=======================================
  Coverage   33.42%   33.43%           
=======================================
  Files        2901     2901           
  Lines       90564    90564           
  Branches    17212    17212           
=======================================
+ Hits        30271    30278    +7     
+ Misses      57899    57892    -7     
  Partials     2394     2394           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

trmartin4 added a commit that referenced this pull request Dec 12, 2024
trmartin4 added a commit that referenced this pull request Dec 12, 2024
* Revert "fix: target workflows not triggering on pull_request_target (#12370)"

This reverts commit 645d36f.

* Revert "[PM-15126] Tighten scope of our client build pipelines to remove reliance on secrets (#12243)"

This reverts commit f8c33ea.
coroiu added a commit to coroiu/clients that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants