Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate new navigation #4833

Merged
merged 192 commits into from
Feb 4, 2020
Merged

Integrate new navigation #4833

merged 192 commits into from
Feb 4, 2020

Conversation

AlistairGempf
Copy link
Contributor

@AlistairGempf AlistairGempf commented Nov 29, 2019

Overall change:
There are a number of issues that need to be resolved in order to be able to release the new navigation. These are:

We have created a feature branch so we can review these changes incrementally, rather than having one large review when we are ready for these to go live.

These pull requests handle aspects of this:

In Progress
Integrate canonical navigation animation #5057

Then:

Done
Navigation: add unit tests and refactor AMP constants #4968
Update nav translations #4969
Spread Navigation props #2802
Add a comment about the hidden attribute #4952
Ensure Nav is always red on desktop #2810
Move media query hooks to Simorgh #2801
Use Brand with Script Link component on services with variants #4948

As well as these issues, which were completed before we decided to use a feature branch:
Navigation: Canonical dropdown integration and dropdown toggling #4571
Navigation: AMP dropdown integration and dropdown toggling #4570


  • I have assigned myself to this PR and the corresponding issues
  • Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
  • If necessary, I have run the local E2E non-smoke tests relevant to my changes (CYPRESS_APP_ENV=local CYPRESS_SMOKE=false npm run test:e2e:interactive)
  • This PR requires manual testing - we will require cross browser testing across browser matrix

@tochwill tochwill merged commit c0917a0 into latest Feb 4, 2020
@tochwill tochwill deleted the integrate-new-navigation branch February 4, 2020 09:07
@amywalkerdev amywalkerdev restored the integrate-new-navigation branch February 4, 2020 09:52
@sareh sareh deleted the integrate-new-navigation branch February 21, 2020 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants