-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate new navigation #4833
Merged
Merged
Integrate new navigation #4833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o integrate-new-navigation
Ensure nav remains visible when screen width changes
Update navigation version
Add E2E test for script link and mobile menu
Ignore failing a11y test
This was referenced Jan 22, 2020
Closed
1 task
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall change:
There are a number of issues that need to be resolved in order to be able to release the new navigation. These are:
We have created a feature branch so we can review these changes incrementally, rather than having one large review when we are ready for these to go live.
These pull requests handle aspects of this:
In Progress
Integrate canonical navigation animation #5057
Then:
Done
Navigation: add unit tests and refactor AMP constants #4968
Update nav translations #4969
Spread Navigation props #2802
Add a comment about the hidden attribute #4952
Ensure Nav is always red on desktop #2810
Move media query hooks to Simorgh #2801
Use Brand with Script Link component on services with variants #4948
As well as these issues, which were completed before we decided to use a feature branch:
Navigation: Canonical dropdown integration and dropdown toggling #4571
Navigation: AMP dropdown integration and dropdown toggling #4570
CYPRESS_APP_ENV=local CYPRESS_SMOKE=false npm run test:e2e:interactive
)