Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Brand with Script Link component on services with variants #4009

Closed
1 task
j-pendlebury opened this issue Sep 30, 2019 · 7 comments
Closed
1 task

Use Brand with Script Link component on services with variants #4009

j-pendlebury opened this issue Sep 30, 2019 · 7 comments
Assignees
@Bopchy
Labels
a11y-swarm An a11y swarm (clarify dev or full team in the desc) needs to be carried out before moving to test ux To be reviewed by UX before merging
Milestone
Script Link (WS FP)

Comments

@j-pendlebury
Copy link
Contributor

j-pendlebury commented Sep 30, 2019 •
edited by tochwill
Loading

⚠️ This should be done at the same time as the Navigation is integrated, as we moved the Skip to content link from the Navigation to the Brand. ⚠️

Is your feature request related to a problem? Please describe.
Import the Script Link component into Simorgh and use on:

  • Serbian
  • UKChina
  • Zhongwen

Describe the solution you'd like
Use the alpha Brand component which includes the Script Link -BBC-archive/psammead#2474

The script link contains an onClick prop, which can be passed an event handler that sets the variant preference cookie when the user interacts with the link.

Add translations for variants:

Site Variant Translation
Serbian bbc.com/serbian/lat Lat
Serbian bbc.com/serbian/cyr Ћир
UK China bbc.com/ukchina/simp 简
UK China bbc.com/ukchina/trad 繁
Zhongwen bbc.com/zhongwen/trad 简
Zhongwen bbc.com/zhongwen/simp 繁

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Testing notes
Will need functionality testing
Will need cypress tests
Will need cross-browser testing
Will need some a11y testing

Dev insight: Will Cypress tests be required or are unit tests sufficient? Will there be any potential regression? etc

  • This feature is expected to need manual testing.

Additional context
WSFRONTPGS-100
@j-pendlebury j-pendlebury added blocked This issue should not be worked on until another internal issue is completed - see desc for details Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. ws-frontpage-stream labels Sep 30, 2019
@AlistairGempf
Copy link
Contributor

Display site not currently on in component, eg. display "Lat" on Cyrillic Serbian site.

@AlistairGempf
Copy link
Contributor

Notify core pod when picking this ticket up.

@AlistairGempf
Copy link
Contributor

Talk @jamesbrumpton about cypress tests re: what is to be e2e and what is unit tests.

@AlistairGempf AlistairGempf removed the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Sep 30, 2019
@AlistairGempf
Copy link
Contributor

Blocked on BBC-archive/psammead#2256

@DenisHdz DenisHdz added blocked This issue should not be worked on until another internal issue is completed - see desc for details a11y-swarm An a11y swarm (clarify dev or full team in the desc) needs to be carried out before moving to test ux To be reviewed by UX before merging and removed blocked This issue should not be worked on until another internal issue is completed - see desc for details labels Oct 9, 2019
@DenisHdz DenisHdz changed the title Use Script Switch component on services with variants Use Script Link component on services with variants Oct 9, 2019
@DenisHdz DenisHdz added this to the Script Link (WS FP) milestone Oct 9, 2019
@j-pendlebury j-pendlebury self-assigned this Oct 15, 2019
@j-pendlebury j-pendlebury removed their assignment Oct 18, 2019
@Bopchy Bopchy self-assigned this Oct 23, 2019
@Bopchy
Copy link
Contributor

Bopchy commented Oct 23, 2019

Blocked on BBC-archive/psammead#2467

@Bopchy Bopchy removed their assignment Oct 23, 2019
@Bopchy Bopchy added the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Oct 23, 2019
@Bopchy Bopchy removed the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Oct 30, 2019
@Bopchy Bopchy assigned Bopchy and unassigned Bopchy Oct 30, 2019
@Bopchy Bopchy added the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Oct 30, 2019
@Bopchy
Copy link
Contributor

Bopchy commented Oct 30, 2019

Blocked on BBC-archive/psammead#2454

@DenisHdz DenisHdz changed the title Use Script Link component on services with variants Use Brand with Script Link component on services with variants Oct 30, 2019
@ghost ghost self-assigned this Dec 4, 2019
@ghost ghost removed their assignment Dec 6, 2019
@tochwill tochwill removed the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Dec 10, 2019
@Bopchy Bopchy self-assigned this Dec 11, 2019
@Bopchy Bopchy mentioned this issue Dec 11, 2019
Merged
6 tasks
@AlistairGempf AlistairGempf mentioned this issue Dec 17, 2019
Merged
4 tasks
@Bopchy
Copy link
Contributor

Bopchy commented Jan 14, 2020

This work has been done here and merged into the Navigation feature branch which is not ready to go live until all of the work is complete.

@Bopchy Bopchy closed this as completed Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bopchy Bopchy

Labels
a11y-swarm An a11y swarm (clarify dev or full team in the desc) needs to be carried out before moving to test ux To be reviewed by UX before merging
Projects
None yet
Milestone
Script Link (WS FP)
Development

No branches or pull requests
5 participants
@tochwill @Bopchy @j-pendlebury @AlistairGempf @DenisHdz