Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Integrate ScriptLink into the Brand Component #2467

Closed
1 task done
ghost opened this issue Oct 23, 2019 · 0 comments · Fixed by #2474
Closed
1 task done

Integrate ScriptLink into the Brand Component #2467

ghost opened this issue Oct 23, 2019 · 0 comments · Fixed by #2474
Labels
ws-home Tasks for the WS Home Team

Comments

@ghost
Copy link

ghost commented Oct 23, 2019

Is your feature request related to a problem? Please describe.
ScriptLink component is to be used within the Brand component such that they share the banner with the brand background colour.

Describe the solution you'd like
Add a scriptLink prop and pass in <ScriptLink>{variant}</ScriptLink> as the value.

Describe alternatives you've considered
Render child passed to Brand. In this case the child would be <ScriptLink>{variant}</ScriptLink>

<Brand>
  <ScriptLink>{variant}</ScriptLink>
</Brand>

Testing notes
[Tester to complete]

Dev insight: Will there be any potential regression? etc

  • This feature is expected to need manual testing.

Additional context
Add any other context or screenshots about the feature request here.

@ghost ghost added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. ws-home Tasks for the WS Home Team labels Oct 23, 2019
@ghost ghost added this to the Script Link (WS FP) milestone Oct 23, 2019
@Bopchy Bopchy assigned ghost Oct 23, 2019
@Bopchy Bopchy removed the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Oct 23, 2019
@ghost ghost closed this as completed in #2474 Oct 29, 2019
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ws-home Tasks for the WS Home Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant