Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure nav remains visible when screen width changes #5163

Merged
merged 1 commit into from
Jan 16, 2020

Conversation

tochwill
Copy link
Contributor

@tochwill tochwill commented Jan 15, 2020

Resolves #5155

If you opened the navigation on mobile, and then resized the window to desktop view, the nav would disappear. This ensures that doesn't happen.

Overall change:
A very high-level summary of easily-reproducible changes that can be understood by non-devs.

Code changes:

  • A bullet point list of key code changes that have been made.
  • When describing code changes, try to communicate how and why you implemented something a specific way, not just what has changed.

  • I have assigned myself to this PR and the corresponding issues
  • I have added labels to this PR for the relevant pod(s) affected by these changes
  • I have assigned this PR to the Simorgh project

Testing:

  • Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
  • If necessary, I have run the local E2E non-smoke tests relevant to my changes (CYPRESS_APP_ENV=local CYPRESS_SMOKE=false npm run test:e2e:interactive)
  • This PR requires manual testing

@tochwill tochwill added bug Something isn't working ws-home labels Jan 15, 2020
@tochwill tochwill self-assigned this Jan 15, 2020
Copy link
Contributor

@AlistairGempf AlistairGempf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. A little surprised none of the Navigation tests need the window.matchMedia to be mocked again, but seems like they're all passing without it. They were never removed in the first place.

Copy link
Contributor

@OlgaLyubin OlgaLyubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested it out and the bug is no longer present.

Copy link
Contributor

@Bopchy Bopchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tochwill tochwill merged commit d98fa5c into integrate-new-navigation Jan 16, 2020
@tochwill tochwill deleted the fix-hidden-navigation branch January 16, 2020 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants