This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Remove aria-hidden from scrollable navigation #2875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tochwill
reviewed
Jan 7, 2020
| </StyledScrollableNav> | ||
| ); | ||
| }; | ||
| export const CanonicalScrollableNavigation = ({ children, dir }) => ( |
There was a problem hiding this comment.
This is now exactly the same as the Amp scrollable nav right? And we probably need the spread props for canonical too for event tracking? Should we just merge them?
OlgaLyubin
reviewed
Jan 7, 2020
tochwill
approved these changes
Jan 7, 2020
|
Thanks Denis! |
DenisHdz
changed the title
4 tasks
6 tasks
|
Looks good to me.Tested the canonical nav with voice over and voice control. |
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall change:
Apple has released a new Accessibility feature with macOS Catalina and iOS 13, called Voice Control, that allows you to control your device entirely just with your voice.
Unfortunately, when applying
aria-hidden: trueto an element, this can't be reached using Voice Control speaking an action, such as "Tap Home".For this reason, we should remove the
aria-hiddenfrom the navigation and also thetab-index:-1from the links as everything will be visible now to the users.Code changes:
aria-hidden:trueto the scrollable navigationtab-index:-1to linksCanonicalScrollableNavigationandAmpScrollableNavigationintoScrollableNavigationisScrollableproparia-hidden