Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate AmpImg component #953

Closed
1 task done
ChrisBAshton opened this issue Nov 15, 2018 · 0 comments
Closed
1 task done

Integrate AmpImg component #953

ChrisBAshton opened this issue Nov 15, 2018 · 0 comments
Assignees
@dr3
Labels
AMP Work related to AMP
Milestone
05. News Image

Comments

@ChrisBAshton
Copy link
Contributor

ChrisBAshton commented Nov 15, 2018 •
edited by sareh
Loading

Is your feature request related to a problem? Please describe.
Depends upon BBC-archive/psammead#241 (to do) and #927 (done).

Once we have our Container and Presentational components, we can integrate into the renderer.

Describe the solution you'd like
Using the PlatformContext added in #982, decide which Image to render (either the canonical or AMP version - exposed by BBC-archive/psammead#241).

Testing notes
Acceptance criteria:

  • We should be able to view an AMP version of an article and inspect any image in that article and find that it is using <amp-img> rather than <img>.

Additional context
#442 is blocked until this is done.
@ChrisBAshton ChrisBAshton added blocked This issue should not be worked on until another internal issue is completed - see desc for details Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. AMP Work related to AMP alpha-2 labels Nov 15, 2018
@ChrisBAshton ChrisBAshton added this to the 05. News Image milestone Nov 15, 2018
This was referenced Nov 19, 2018
Closed
Closed
@ChrisBAshton ChrisBAshton added alpha-2 and removed Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. alpha-3 labels Dec 17, 2018
@sareh sareh mentioned this issue Dec 31, 2018
Closed
4 tasks
@bcmn bcmn mentioned this issue Jan 4, 2019
Closed
1 task
@sareh sareh mentioned this issue Jan 9, 2019
Closed
1 task
@dr3 dr3 self-assigned this Jan 10, 2019
@dr3 dr3 removed the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Jan 10, 2019
@dr3 dr3 mentioned this issue Jan 11, 2019
Merged
4 tasks
@jamesbrumpton jamesbrumpton mentioned this issue Jan 14, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dr3 dr3

Labels
AMP Work related to AMP
Projects
None yet
Milestone
05. News Image
Development

No branches or pull requests
3 participants
@BogdanDogaru @ChrisBAshton @dr3