-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMP validation for all scenarios #442
Comments
Same question as #441 really, is to this run locally or on CI? We have an AMP validator that runs on a Lambda and is validates every single published AMP article, posting to Slack with the error's (if there are any) if you are thinking of this as more of an end to end test maybe using the same validator setup we are now would be a good idea? The current validator runs on both test and live. |
Blocked pending #873 @hindsc52 in the future when all the validation errors are sorted we will want to run this in CI but at present it would break CI. |
Related to #1122. |
I don't believe we need to validate every article, but this #2220 is very valuable and quite similar. |
Is your feature request related to a problem? Please describe.
After steps #440 (creating amp routes) and #441 (validating a single scenario) have been completed, we want to run the AMP validation script against all article scenarios.
Describe the solution you'd like
Update the amp validation npm script to run against all of the article scenarios and output their results in the console.
If there are any errors listed in the output, a separate issue should be opened to create an AMP-compliant component & container that addresses those points.
Additional context
See instructions here https://www.ampproject.org/docs/fundamentals/validate#command-line-tool and here https://www.npmjs.com/package/amphtml-validator
The text was updated successfully, but these errors were encountered: