Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AMP Validation to Jenkins pipeline #1122

Closed
1 task done
bcmn opened this issue Jan 4, 2019 · 1 comment
Closed
1 task done

Add AMP Validation to Jenkins pipeline #1122

bcmn opened this issue Jan 4, 2019 · 1 comment
Assignees
Labels
AMP Work related to AMP

Comments

@bcmn
Copy link
Contributor

bcmn commented Jan 4, 2019

Blocked on #953.

Describe the solution you'd like
Currently, the img/amp-img errors are the only remaining warnings that are shown when running the AMP validation script. Once the ticket above is done, the validation should pass. Once here, we should add the AMP validation script to the Jenkins pipeline.

Testing notes
[Tester to complete]

Dev insight: When viewing Jenkins job output for the branch, I can see that the AMP validator is run & passing. Deliberately breaking an AMP behaviour would trigger the job to fail, etc.

Additional context
Add any other context or screenshots about the feature request here.

@bcmn bcmn added the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Jan 4, 2019
@bcmn bcmn added the alpha-3 label Jan 4, 2019
@ChrisBAshton ChrisBAshton added goal-of-the-week AMP Work related to AMP labels Jan 4, 2019
@ChrisBAshton ChrisBAshton added blocked This issue should not be worked on until another internal issue is completed - see desc for details and removed Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. labels Jan 5, 2019
@ChrisBAshton
Copy link
Contributor

Refined - we're just gonna run the validator against one URL, as we currently do, but in Jenkinsfile - as a failing step.

In #442 we'll look at expanding the list of URLs we test against.

@dr3 dr3 self-assigned this Jan 11, 2019
@dr3 dr3 mentioned this issue Jan 11, 2019
4 tasks
@ChrisBAshton ChrisBAshton removed the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Jan 14, 2019
@dr3 dr3 closed this as completed in #1155 Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AMP Work related to AMP
Projects
None yet
Development

No branches or pull requests

3 participants