-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMP validation for a single scenario #441
Comments
Is the idea here to just make sure one does not break the AMP validation when making local changes? If so then this will be fine. We have been using the AMP validator for our current AMP setup since the initial launch and have not experienced any issues. |
The aim in this specific Issue is to make the AMP validation output visible. |
Ahhh I see, makes perfect sense to me in that case. :) |
Resolved as fixed, in #492. |
Is your feature request related to a problem? Please describe.
After an AMP route has been created (#440) we want to be able to run a validation cli tool against a single page to see if it passes
Here is a page that explains what the validation tool does: https://www.ampproject.org/docs/fundamentals/validate
Describe the solution you'd like
To have an
npm
script in thepackage.json
file that runs theamphtml-validator
cli tool against a single article, e.g./article/amp/scenario-01
. The output should be displayed in the console. This validation does not need to be run on CI at this point. This will be handled in a future issue.https://www.ampproject.org/docs/fundamentals/validate#command-line-tool
If there are any errors listed in the output, a separate issue should be opened to create an AMP-compliant component & container that addresses those points.
Describe alternatives you've considered
Since this is the recommended way to validate AMP pages, other options were not considered.
The text was updated successfully, but these errors were encountered: