This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 54
Update Image to include AmpImg & add srcset prop #241
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug found: When running storybook I'd suggest making this a separate issue to this PR. |
bcmn
reviewed
Jan 2, 2019
bcmn
reviewed
Jan 2, 2019
packages/components/psammead-image/src/testHelpers/fixtureData.js
Outdated
Show resolved
Hide resolved
dr3
reviewed
Jan 2, 2019
ChrisBAshton
suggested changes
Jan 3, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start, thanks Sareh
packages/components/psammead-image/src/testHelpers/fixtureData.js
Outdated
Show resolved
Hide resolved
Co-Authored-By: dr3 <[email protected]>
Co-Authored-By: dr3 <[email protected]>
dr3
reviewed
Jan 4, 2019
This was referenced Jan 9, 2019
1 task
12 tasks
sareh
dismissed stale reviews from ChrisBAshton, bcmn, pjlee11, and dr3
via
January 9, 2019 15:41
ab5d1cf
dr3
approved these changes
Jan 9, 2019
pjlee11
approved these changes
Jan 9, 2019
LGTM 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of bbc/simorgh#929
Testing notes
When you visit storybook, you should see two sets of stories in the menu. Image - AmpImg and Image - Img.
The AmpImg stories should load correctly, with all associated Amp HTML.
http://localhost:8080/?selectedKind=Image%20-%20AmpImg