Integrate amp img #1153
Merged
Integrate amp img #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcmn
previously approved these changes
Jan 11, 2019
pjlee11
reviewed
Jan 14, 2019
bcmn
previously approved these changes
Jan 14, 2019
Co-Authored-By: dr3 <[email protected]>
bcmn
previously approved these changes
Jan 14, 2019
ChrisBAshton
suggested changes
Jan 14, 2019
| platform === 'amp' ? ( | ||
| <AmpImg | ||
| alt={alt} | ||
| attribution={copyright || ''} |
There was a problem hiding this comment.
Hmm so this means we'll be adding an amp attribution and rendering the copyright below it. How is attribution actually used? Is it meta information or is it read out to screen readers?
pjlee11
reviewed
Jan 14, 2019
bcmn
approved these changes
Jan 14, 2019
|
LGTM 👍 |
2 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #953
Integrates amp image in simorgh