Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EKS Workshop update to EKS 1.16 #85

Merged
merged 6 commits into from
Jul 15, 2020
Merged

EKS Workshop update to EKS 1.16 #85

merged 6 commits into from
Jul 15, 2020

Conversation

ruecarlo
Copy link
Contributor

Closes: #75 , Closes: #72, Closes: #64, Closes: #62 , Closes: #61 , Closes: #60 , Closes: #65

Description of changes:

  • Updated to helm 3 and added elements for auto-completion of helm commands and all the entries in the workshop where helm is used.
  • Removes Mixed Instance Group with on-demand and spot in the same group (eksctl does not suppor this bootstrapping mode and is not recommended anyway with Cluster Autoscaler)
  • Commented the kube-resource-report temporarily until ClusterRole and binding section get fixed in the upstream project.
  • Cluster Autoscaler Moved to new repository and updated to 1.16, Configuration changed to auto-detect autoscaling groups
  • Kubeclt and eksctl upgraded to meet requirements for 1.16 (soon to be changed to 1.17)
  • AWS termination handler is now deployed to on-demand groups and we explain why that is a best practice.
  • Spot instance advisor section is not used anymore when selecting instances; Instead we have modified this to use amazon ec2-instance-selector

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ruecarlo ruecarlo mentioned this pull request Jul 15, 2020
Closed
@ruecarlo ruecarlo self-assigned this Jul 15, 2020
@ruecarlo ruecarlo requested review from ranshn and ivallhon July 15, 2020 02:46
ivallhon
ivallhon reviewed Jul 15, 2020
View reviewed changes
Copy link
Contributor

@ivallhon ivallhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just added a couple of suggestions

content/using_ec2_spot_instances_with_eks/scaling/deploy_ca.md Show resolved Hide resolved
content/using_ec2_spot_instances_with_eks/spotworkers/selecting_instance_types.md Show resolved Hide resolved
@ruecarlo ruecarlo removed the request for review from ranshn July 15, 2020 09:47
@ruecarlo ruecarlo merged commit 8550bf2 into awslabs:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivallhon ivallhon ivallhon approved these changes

Assignees

@ruecarlo ruecarlo

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ruecarlo @ivallhon