Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm3 #79

Closed
wants to merge 2 commits into from
Closed

Helm3 #79

wants to merge 2 commits into from

Conversation

allamand
Copy link
Contributor

@allamand allamand commented Jun 3, 2020

Issue #, if available: Fix #65

Description of changes: Upgrade workshop to uses helm v3 which supress the needs for tiller and increase security while reducing complexity

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ruecarlo ruecarlo self-requested a review June 3, 2020 16:54
Copy link
Contributor

@ivallhon ivallhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution! I left a comment regarding bash-completion not being pre-installed on Cloud9, so this needs to be added to pre-requisites.

The PR looks well but helm3 changes break some of the workshop steps due to for example helm3 not automatically creating a namespace if it doesn't exist or the --name parameter changed by a positional argument. More info here. Could you please incorporate the additional required changes to the workshop to use helm3?

Comment on lines +31 to +34
helm completion bash >> ~/.bash_completion
. /etc/profile.d/bash_completion.sh
. ~/.bash_completion
source <(helm completion bash)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that bash-completion doesn't come pre-installed on Cloud9, so installing it needs to be included as a step on pre-requisites

@ruecarlo
Copy link
Contributor

I'm closing this Pull request, the changes are being added as part of #85, including the bash completion pre-requirements

@ruecarlo ruecarlo closed this Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EKS Workshop - Update workshop to use Helm 3
3 participants