VSOCK socket client would almost always fail

[solokacher]

Describe the bug

Function s_update_local_endpoint(struct aws_socket *socket) defined at
source/posix/socket.c#L273 has the following logic:

        /* VSOCK port is 32bit, but aws_socket_endpoint.port is only 16bit.
         * Hopefully this isn't an issue, since users can only pass in 16bit values.
         * But if it becomes an issue, we'll need to make aws_socket_endpoint more flexible */
        if (s->svm_port > UINT16_MAX) {
            AWS_LOGF_ERROR(
                AWS_LS_IO_SOCKET,
                "id=%p fd=%d: aws_socket_endpoint can't deal with VSOCK port > UINT16_MAX",
                (void *)socket,
                socket->io_handle.data.fd);
            return aws_raise_error(AWS_IO_SOCKET_INVALID_ADDRESS);
        }
        tmp_endpoint.port = (uint16_t)s->svm_port;

When it is used as a client, it would almost always fail, as the ephemeral port grabbed from the system is likely be large number. How did we test this code?

Expected Behavior

aws_socket_connect() should succeed

Current Behavior

Failure with aws_socket_endpoint can't deal with VSOCK port > UINT16_MAX

Reproduction Steps

Create a client and connect to any VSOCK address

Possible Solution

use 32 bit port number

Additional Information/Context

No response

aws-c-io version used

version containing df07e42

Compiler and version used

clang14

Operating System and version

Linux

[graebm]

VSOCK support isn't 100% complete, as you've discovered. Someone submitted this partial support, and we integrated it to unblock them, but never bound it out to any other languages.

Finishing support would mean widening aws_socket_endpoint.port, add error-checking anywhere we cast it gets narrowed to 16bits, widen the value in our other language bindings, etc, etc, etc. It's not on our current roadmap.

I assume you're trying to use this directly from C? What's your use case?

[github-actions]

Greetings! It looks like this issue hasn’t been active in longer than a week. We encourage you to check if this is still an issue in the latest release. Because it has been longer than a week since the last update on this, and in the absence of more information, we will be closing this issue soon. If you find that this is still a problem, please feel free to provide a comment or add an upvote to prevent automatic closure, or if the issue is already closed, please feel free to open a new one.

[graebm]

I'm working on a fix...

[graebm]

It is done
port is 32bits now everywhere