Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change port from uint16_t to uint32_t, to support VSOCK #338

Merged
merged 7 commits into from
Dec 30, 2023
Merged

Conversation

graebm
Copy link
Contributor

@graebm graebm commented Dec 13, 2023

Issue: awslabs/aws-c-io#576

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (eac4be3) 82.40% compared to head (f2df7c3) 82.41%.

Files Patch % Lines
source/v5/mqtt5_options_storage.c 66.66% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #338   +/-   ##
=======================================
  Coverage   82.40%   82.41%           
=======================================
  Files          20       20           
  Lines        8775     8779    +4     
=======================================
+ Hits         7231     7235    +4     
  Misses       1544     1544           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bretambrose bretambrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have concerns, let's talk about validation and testing updates too.

@graebm graebm requested a review from bretambrose December 18, 2023 21:07
@graebm graebm merged commit 17ee24a into main Dec 30, 2023
31 checks passed
@graebm graebm deleted the 32bit-port branch December 30, 2023 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants