Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change port from uint16_t to uint32_t, to support VSOCK #394

Merged
merged 3 commits into from
Dec 30, 2023
Merged

Conversation

graebm
Copy link
Contributor

@graebm graebm commented Dec 13, 2023

Issue: awslabs/aws-c-io#576

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7dd72a9) 89.10% compared to head (f45bc4a) 89.09%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #394      +/-   ##
==========================================
- Coverage   89.10%   89.09%   -0.02%     
==========================================
  Files          21       21              
  Lines        6170     6169       -1     
==========================================
- Hits         5498     5496       -2     
- Misses        672      673       +1     
Files Coverage Δ
source/s3_client.c 88.28% <100.00%> (ø)
source/s3_endpoint.c 90.37% <ø> (-0.08%) ⬇️

... and 1 file with indirect coverage changes

@graebm graebm merged commit 1dd55be into main Dec 30, 2023
30 checks passed
@graebm graebm deleted the 32bit-port branch December 30, 2023 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants