Add Build Image for dotnetcore3.1 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisoverzero
force-pushed
the
feature/dotnetcore3.1
branch
from
b9476a7 to
8b32a16
Compare
|
I noticed now that other pull requests go against the
If I should rebase and point this elsewhere, please do let me know. |
hoffa
reviewed
Aug 27, 2021
chrisoverzero
force-pushed
the
feature/dotnetcore3.1
branch
from
2fddba4 to
495a501
Compare
chrisoverzero
force-pushed
the
feature/dotnetcore3.1
branch
from
495a501 to
f4ee642
Compare
|
Ecch, I'm not super adroit at rebasing across fork and branch, but I believe that's done it. Thanks so much! |
sriram-mv
requested changes
Aug 27, 2021
...and Get `make pr` to Work
- Suppress First-Time Run Messages - Redirect Nuget Warmup Output - Justify Nuget Warmup Procedure
Somehow, I failed to notice that the very next line was also setting environment variables.
...Which Is Compatible with aws-lambda-builders (a.k.a. `sam build`)
chrisoverzero
force-pushed
the
feature/dotnetcore3.1
branch
from
304cd44 to
42a3811
Compare
sriram-mv
reviewed
Aug 27, 2021
sriram-mv
approved these changes
Aug 27, 2021
hoffa
reviewed
Aug 27, 2021
Co-authored-by: Chris Rehn <[email protected]>
hoffa
approved these changes
Aug 27, 2021
|
The image is now available as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and Get
make prto WorkIssue #, if available: #13
Description of changes:
Adds a
dotnetcore3.1build image in the style of the other build images – pulling its base from Public ECR as Python 3.9 does. The pre-invocation ofdotnetis from LambCI, and attributed appropriately.Notes:
make prworking correctly. I tried to keep the changes for that to a minimum.pytestwants the unit tests to be run in random order. I don't know enough about it to know whether that plugin is loaded for everyone or just for me, so I did not add it.AWS_EXECUTION_ENV=AWS_Lambda_dotnetcore3.1for the build image, but that should be set in the emulation image, or whatever it is that's used forsam local invoke.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.