Skip to content

Commit

Permalink
Address Pull Request Feedback
Browse files Browse the repository at this point in the history
- Suppress First-Time Run Messages
- Redirect Nuget Warmup Output
- Justify Nuget Warmup Procedure
  • Loading branch information
chrisoverzero committed Aug 27, 2021
1 parent cf3eee5 commit f4ee642
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
6 changes: 5 additions & 1 deletion build-image-src/Dockerfile-dotnetcore31
Original file line number Diff line number Diff line change
Expand Up @@ -55,15 +55,19 @@ ENV DOTNET_ROOT=/var/lang/bin

# Install .NET build tools

# Suppress first-time output.
ENV DOTNET_NOLOGO=true

ENV PATH=/root/.dotnet/tools:$PATH \
AWS_EXECUTION_ENV=AWS_Lambda_dotnetcore3.1 \
DOTNET_CLI_TELEMETRY_OPTOUT=1 \
NUGET_XMLDOC_MODE=skip

# Warm up the nuget cache once now for faster startup on each use.
RUN curl -L https://dot.net/v1/dotnet-install.sh | bash -s -- -c 3.1 -i "${DOTNET_ROOT}" && \
mkdir /tmp/warmup && \
cd /tmp/warmup && \
dotnet new && \
dotnet new > /dev/null && \
cd / && \
rm -rf /tmp/warmup /tmp/NuGetScratch /tmp/.dotnet

Expand Down
3 changes: 1 addition & 2 deletions tests/test_build_images.py
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ def test_packages(self):
self.assertTrue(self.check_package_output("python --version", "Python 3.8."))
self.assertTrue(self.is_package_present("pip"))


# class TestBIPython39(BuildImageBase):
# __test__ = True

Expand All @@ -176,8 +177,6 @@ def test_packages(self):
# self.assertTrue(self.is_package_present("pip"))




class TestBIDotNetCore31(BuildImageBase):
__test__ = True

Expand Down

0 comments on commit f4ee642

Please sign in to comment.