Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Support dotnet lambda container builds #4453

Open
1davidmichael opened this issue Dec 1, 2022 · 3 comments
Open

Feature request: Support dotnet lambda container builds #4453

1davidmichael opened this issue Dec 1, 2022 · 3 comments

Comments

@1davidmichael
Copy link

Describe your idea/feature/enhancement

All other language run-times support the --use-container option for sam build except dotnet runtimes. With the addition of build images for dotnet it should now be possible to do this.

I've tested this with a quick hack here and it appears to work. I was able to successfully build and publish a dotnet6 runtime lambda via the following commands:

sam build -u
sam deploy --config-file samconfig.toml

However, I am guessing the change from read-only to read-write for the manifest dir is not ideal.

Proposal

Add support for dotnet lambda builds via docker containers to align with other runtime supported builds.

Things to consider:

  1. May require updates to the docker build logic to support how it is handled via dotnet
@1davidmichael 1davidmichael added stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. type/feature Feature request labels Dec 1, 2022
@torresxb1
Copy link
Contributor

Thanks for the feature request! Write permissions would indeed require some caution here. Let me bring this up to the team for discussion.

@torresxb1 torresxb1 removed the stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. label Dec 3, 2022
@torresxb1
Copy link
Contributor

Hi @1davidmichael, wanted to give an update after discussing with the team: this is something that was on our map already, and we're in the process of prioritizing it, but we can't give any timelines at the moment.

@1davidmichael
Copy link
Author

@torresxb1 awesome to here. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants