Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .NET runtimes #13

Closed
1davidmichael opened this issue Jun 25, 2021 · 5 comments
Closed

Add .NET runtimes #13

1davidmichael opened this issue Jun 25, 2021 · 5 comments

Comments

@1davidmichael
Copy link

Description

Currently there are not provided docker images for the .NET runtime, and the sam build command does not support the --use-container flag. This makes typical build and deploy workflows with SAM not working consistently for .NET projects. It would be great if a Docker image could be provided and the sam cli updated to work with the container.

Benefits

Ensures consistent behavior for all AWS Lambda supported runtimes by the AWS SAM cli and build/deploy workflow.

Request

Add .NET Dockerfiles supporting AWS runtimes

  • Dockerfile-dotnetcore31
  • Dockerfile-dotnetcore21
@chrisoverzero
Copy link
Contributor

chrisoverzero commented Aug 9, 2021

It's especially confusing that such a container is listed on the ECR Public Gallery, but has no data/tags associated with it.

This makes typical build and deploy workflows with SAM not working consistently for .NET projects.

Even more than consistency, this lack prevents certain optimizations for .NET Lambda Functions. Deploying an application as ReadyToRun helps startup times significantly. To do it, the application has to be built on the deployment target (barring some limited cross-compilation). This is much easier with an official SAM build image.

@mr-davidc
Copy link

Will this issue also cover introducing an AWS SAM build image for net5.0 ?

@chrisoverzero
Copy link
Contributor

I do not intend to, at least. net5.0 is not a supported Lambda runtime.

@mr-davidc
Copy link

Yea of course @chrisoverzero.

I was thinking perhaps an AW SAM build image for net5.0 would only be for building Lambdas targeting net5.0 with PackageType: Image. Kind of like you can do using the AWS SAM CLI on your local machine.

@ssenchenko
Copy link

Image for .NET Core 3.1 merged. Closing this issue.
There are no plans to add .NET Core 2.1 or .NET 5

mndeveci added a commit that referenced this issue Nov 3, 2022
* Adding dotnet7 image

* Update to runtime image base

* Add .NET 7 to attribution

* Add dummy net7 test, add net7 to makefile

* Use x86 specifically since dotnet7 is single arch

* add dotnet7 build job

Co-authored-by: Mehmet Nuri Deveci <[email protected]>
mndeveci added a commit that referenced this issue Nov 3, 2022
* Adding dotnet7 image

* Update to runtime image base

* Add .NET 7 to attribution

* Add dummy net7 test, add net7 to makefile

* Use x86 specifically since dotnet7 is single arch

* add dotnet7 build job

Co-authored-by: Mehmet Nuri Deveci <[email protected]>

Co-authored-by: Beau Gosse <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants