chore: Remove remaining modules from project, update workflows now that modules are removed #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryantbiggs
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Error
bryantbiggs
commented
Jul 24, 2023
| tflint-version: ${{ env.TFLINT_VERSION }} | ||
| args: 'terraform_validate --color=always --show-diff-on-failure --files $(ls *.tf)' | ||
|
|
||
| preCommitMaxVersion: |
There was a problem hiding this comment.
This was running pre-commit run -a from the root of the project. Now we are running this per pattern which means we can remove this and also speed up the CI checks
bryantbiggs
force-pushed
the
chore/remove-modules
branch
from
ca8207f to
559c444
Compare
bryantbiggs
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Error
…at modules are removed
bryantbiggs
force-pushed
the
chore/remove-modules
branch
from
559c444 to
1537a77
Compare
bryantbiggs
temporarily deployed
to
EKS Blueprints Test
GitHub Actions
Inactive
askulkarni2
approved these changes
Jul 24, 2023
bryantbiggs
temporarily deployed
to
EKS Blueprints Test
GitHub Actions
Inactive
jzanillo
added a commit
to relay-delivery/terraform-aws-eks-blueprints
that referenced
this pull request
Aug 2, 2023
…s now that modules are removed (aws-ia#1699)" This reverts commit a1de62c.
jzanillo
added a commit
to relay-delivery/terraform-aws-eks-blueprints
that referenced
this pull request
Aug 2, 2023
…at modules are removed (aws-ia#1699)
2 tasks
ananth102
added a commit
to awslabs/kubeflow-manifests
that referenced
this pull request
Aug 8, 2023
**Which issue is resolved by this Pull Request:** Terraform deployments are not working because eks blueprints before v4.32.1 did not pin their version in the main.tf file. As a result terraform pulled the modules from the main branch. Last week eks blueprints removed the modules as part of their refactoring effort which breaks any version before v4.32.1. Further reading: aws-ia/terraform-aws-eks-blueprints#1699 aws-ia/terraform-aws-eks-blueprints#1630 (comment) **Description of your changes:** Upgrade terraform-aws-eks-blueprints from `v4.31.0` to `v4.32.1` **Testing:** - [ ] Unit tests pass - [x] e2e tests pass - Details about new tests (If this PR adds a new feature) - Details about any manual tests performed By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
rodrigobersa
pushed a commit
that referenced
this pull request
Aug 9, 2023
…at modules are removed (#1699)
rodrigobersa
added a commit
that referenced
this pull request
Aug 9, 2023
chore(deps): Bump github/codeql-action from 2.21.0 to 2.21.1 (#1703) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> fix: Correct doc name for privatelink example (#1704) chore: Clean up of the README (#1705) chore(deps): Bump github/codeql-action from 2.21.1 to 2.21.2 (#1706) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> chore: Remove remaining modules from project, update workflows now that modules are removed (#1699) fix: Change EKS addons to use EKS Blueprint addons module (#1718) chore(deps): Bump github/codeql-action from 2.21.2 to 2.21.3 (#1720) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Adding `README`. Running `pre-commit` Adding example Adding `README`. Running `pre-commit`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How was this change tested?
pre-commit run -awith this PRAdditional Notes