Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create support an external addons #2701

Conversation

matheusmazzoni
Copy link

Description

In this new functionality the idea is
we have the possibility to install external/additional addons, that is, the addons that are not installable by the aws_eks_addon resource.

Motivation and Context

Currently there are components/addons that are ideal for a functional installation of an EKS Cluster, at least to have a good functioning and that it is possible to implement applications without great complexities.
We have examples of addons that fulfill this role: Cluster Autoscaler, Metric Server, AWS Load Balancer Controller, etc.
In this way, the creation of additional/external addons opens the possibility of implementing several others (currently we contemplate only Cluster Autoscaler).

Breaking Changes

NDA

How Has This Been Tested?

  • [ x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • [ x] I have tested and validated these changes using one or more of the provided examples/* projects
  • [ x] I have executed pre-commit run -a on my pull request

Mentions

@snifbr - Great technical support and amazing conversartion <3

@bryantbiggs
Copy link
Member

we are not adding those here - you can check out https://github.com/aws-ia/terraform-aws-eks-blueprints-addons

@matheusmazzoni
Copy link
Author

@bryantbiggs Thanks for the tip! It was inside the blueprints repository.

@bryantbiggs
Copy link
Member

whats inside the blueprints repository?

@matheusmazzoni
Copy link
Author

matheusmazzoni commented Jul 28, 2023

Sorry for my bad english haha.
I just realized that this code is in another repository.
In addtional, @bryantbiggs, there are two repositories with addons: the one you showed me (terraform-aws-eks-blueprints-addons) and this one terraform-aws-eks-blueprints. Which one the "community" recomends to use or it's better?

@bryantbiggs
Copy link
Member

bryantbiggs commented Jul 28, 2023

https://github.com/aws-ia/terraform-aws-eks-blueprints-addons

Modules/addons are no longer available in https://github.com/aws-ia/terraform-aws-eks-blueprints and the last remaining helper modules will be removed soon aws-ia/terraform-aws-eks-blueprints#1699

@matheusmazzoni
Copy link
Author

Nice! Now I know which repository I will contribute haha. Thanks @bryantbiggs!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants