-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove remaining modules from project, update workflows now that modules are removed #1699
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -60,9 +60,6 @@ jobs: | |
- uses: dorny/paths-filter@v2 | ||
id: changes | ||
with: | ||
# We only need to check Terraform files for the current directory | ||
# because the `preCommitMaxVersion` job will run the full, | ||
# exhaustive checks (always) | ||
filters: | | ||
src: | ||
- '${{ matrix.directory }}/*.tf' | ||
|
@@ -87,71 +84,10 @@ jobs: | |
directory: ${{ matrix.directory }} | ||
|
||
- name: Pre-commit Terraform ${{ steps.minMax.outputs.minVersion }} | ||
uses: clowdhaus/terraform-composite-actions/[email protected] | ||
# Run only validate pre-commit check on min version supported | ||
if: ${{ matrix.directory != '.' && steps.changes.outputs.src== 'true' }} | ||
with: | ||
terraform-version: ${{ steps.minMax.outputs.minVersion }} | ||
tflint-version: ${{ env.TFLINT_VERSION }} | ||
args: 'terraform_validate --color=always --show-diff-on-failure --files ${{ matrix.directory }}/*' | ||
|
||
- name: Pre-commit Terraform ${{ steps.minMax.outputs.minVersion }} | ||
uses: clowdhaus/terraform-composite-actions/[email protected] | ||
# Run only validate pre-commit check on min version supported | ||
if: ${{ matrix.directory == '.' && steps.changes.outputs.src== 'true' }} | ||
with: | ||
terraform-version: ${{ steps.minMax.outputs.minVersion }} | ||
tflint-version: ${{ env.TFLINT_VERSION }} | ||
args: 'terraform_validate --color=always --show-diff-on-failure --files $(ls *.tf)' | ||
|
||
preCommitMaxVersion: | ||
name: Max TF pre-commit | ||
runs-on: ubuntu-latest | ||
needs: collectInputs | ||
steps: | ||
- name: Harden Runner | ||
uses: step-security/harden-runner@v2 | ||
with: | ||
egress-policy: audit | ||
|
||
- name: Remove default Terraform | ||
run: rm -rf $(which terraform) | ||
|
||
- name: Checkout | ||
uses: actions/checkout@v3 | ||
|
||
- uses: dorny/paths-filter@v2 | ||
id: changes | ||
with: | ||
filters: | | ||
src: | ||
- '**/*.tf' | ||
|
||
- name: Config Terraform plugin cache | ||
if: steps.changes.outputs.src== 'true' | ||
run: mkdir --parents ${{ env.TERRAFORM_DOCS_VERSION }} | ||
|
||
- name: Cache Terraform | ||
uses: actions/cache@v3 | ||
if: steps.changes.outputs.src== 'true' | ||
with: | ||
path: ${{ env.TF_PLUGIN_CACHE_DIR }} | ||
key: ${{ runner.os }}-terraform-${{ hashFiles('**/.terraform.lock.hcl') }} | ||
restore-keys: ${{ runner.os }}-terraform- | ||
|
||
- name: Install tfsec | ||
if: steps.changes.outputs.src== 'true' | ||
run: curl -sSLo ./tfsec https://github.com/aquasecurity/tfsec/releases/download/${{ env.TFSEC_VERSION }}/tfsec-$(uname)-amd64 && chmod +x tfsec && sudo mv tfsec /usr/bin/ | ||
|
||
- name: Terraform min/max versions | ||
id: minMax | ||
uses: clowdhaus/[email protected] | ||
if: steps.changes.outputs.src== 'true' | ||
|
||
- name: Pre-commit Terraform ${{ steps.minMax.outputs.maxVersion }} | ||
uses: clowdhaus/terraform-composite-actions/[email protected] | ||
if: steps.changes.outputs.src== 'true' | ||
with: | ||
terraform-version: ${{ steps.minMax.outputs.maxVersion }} | ||
terraform-docs-version: ${{ env.TERRAFORM_DOCS_VERSION }} | ||
tflint-version: ${{ env.TFLINT_VERSION }} | ||
args: '--files ${{ matrix.directory }}/*' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was running
pre-commit run -a
from the root of the project. Now we are running this per pattern which means we can remove this and also speed up the CI checks