Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change EKS addons to use EKS Blueprint addons module #1718

Merged
merged 1 commit into from
Aug 9, 2023
Merged

fix: Change EKS addons to use EKS Blueprint addons module #1718

merged 1 commit into from
Aug 9, 2023

Conversation

tiagoReichert
Copy link
Contributor

Changed addons to blueprint

Description

Changing the addons from EKS to EKS Blueprints Addons fixed error messagens on vpc-cni.

Motivation and Context

  • Resolves #

How was this change tested?

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Additional Notes

Changed addons to blueprint
@tiagoReichert tiagoReichert requested a review from a team as a code owner August 7, 2023 19:20
@tiagoReichert tiagoReichert temporarily deployed to EKS Blueprints Test August 7, 2023 19:20 — with GitHub Actions Inactive
@tiagoReichert tiagoReichert changed the title Error message fix: Changed addons to blueprint fix: Changed addons to blueprint Aug 7, 2023
@bryantbiggs
Copy link
Contributor

what is the motivation for this change?

@tiagoReichert
Copy link
Contributor Author

To remove the following message:

│ Warning: Argument is deprecated
│
│   with module.eks.aws_eks_addon.this["coredns"],
│   on .terraform/modules/eks/main.tf line 392, in resource "aws_eks_addon" "this":
│  392:   resolve_conflicts        = try(each.value.resolve_conflicts, "OVERWRITE")
│
│ The "resolve_conflicts" attribute can't be set to "PRESERVE" on initial resource creation. Use "resolve_conflicts_on_create" and/or "resolve_conflicts_on_update" instead
│
│ (and 2 more similar warnings elsewhere)

@bryantbiggs
Copy link
Contributor

Unfortunately this won't remove that message

@tiagoReichert
Copy link
Contributor Author

It worked here, can you try to reproduce?

@bryantbiggs bryantbiggs changed the title fix: Changed addons to blueprint fix: Change EKS addons to use EKS Blueprint addons module Aug 9, 2023
Copy link
Contributor

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh nice, it does bypass that warning even though the deprecated resource is still there (though, not used)
image

Thank you! (ignoring the github action cache hit error - will monitor on subsequent PRs)

@bryantbiggs bryantbiggs merged commit 466a71a into aws-ia:main Aug 9, 2023
rodrigobersa added a commit that referenced this pull request Aug 9, 2023
chore(deps): Bump github/codeql-action from 2.21.0 to 2.21.1 (#1703)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

fix: Correct doc name for privatelink example (#1704)

chore: Clean up of the README (#1705)

chore(deps): Bump github/codeql-action from 2.21.1 to 2.21.2 (#1706)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore: Remove remaining modules from project, update workflows now that modules are removed (#1699)

fix: Change EKS addons to use EKS Blueprint addons module (#1718)

chore(deps): Bump github/codeql-action from 2.21.2 to 2.21.3 (#1720)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Adding `README`. Running `pre-commit`

Adding example

Adding `README`. Running `pre-commit`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants