docs: Add document for v5 direction to share with the broader community #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryantbiggs
temporarily deployed
to
EKS Blueprints Test
GitHub Actions
Inactive
|
great stuff here. |
|
OMG, it wil be big change. In 5.x structure, you miss "terraform-aws-eks-teams" |
Ah yes, thank you. Theres a few other details missing as well that I'll add soon |
… into docs/v5-direction
bryantbiggs
temporarily deployed
to
EKS Blueprints Test
GitHub Actions
Inactive
This was referenced Jan 21, 2023
Closed
Closed
bryantbiggs
temporarily deployed
to
EKS Blueprints Test
GitHub Actions
Inactive
bryantbiggs
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Error
bryantbiggs
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Error
This was referenced Feb 6, 2023
|
here is an early look at what v5 might look like https://github.com/aws-ia/terraform-aws-eks-blueprints/tree/refactor/v5-part-deux |
askulkarni2
approved these changes
Feb 13, 2023
vara-bonthu
reviewed
Feb 22, 2023
DIRECTION_v5.md
Outdated
| | | └── examples/ | ||
| | ├── terraform-aws-eks-blueprints/ | ||
| | | └── examples/ | ||
| | ├── eks-addons/ # Contains addons in supported formats (Terraform, ArgoCD, and FluxCD (future)) |
There was a problem hiding this comment.
Is this going to be called as terraform-aws-eks-blueprints-addons ?
There was a problem hiding this comment.
name updated in 0a80238
DIRECTION_v5.md
Outdated
| | ├── terraform-aws-eks-blueprints/ | ||
| | | └── examples/ | ||
| | ├── eks-addons/ # Contains addons in supported formats (Terraform, ArgoCD, and FluxCD (future)) | ||
| | ├── terraform-aws-eks-addon/ # Module for creating Terraform based addon (IRSA + Helm chart) |
There was a problem hiding this comment.
Is this terraform-aws-kubernetes-addon ?
There was a problem hiding this comment.
name updated in 0a80238
DIRECTION_v5.md
Outdated
| | | | ├── variables.tf | ||
| | | | └── versions.tf | ||
| | | └── <other-addons>/ | ||
| | ├── terraform-aws-eks-multi-tenancy/ # Module for creating Kubernetes multi-tenancy constructs |
There was a problem hiding this comment.
Is this terraform-aws-eks-multi-tenancy same as terraform-aws-eks-teams?
There was a problem hiding this comment.
name updated in 0a80238
DIRECTION_v5.md
Outdated
|
|
||
| 1. EKS Blueprints will remove its Amazon EKS cluster Terraform module components (control plane, EKS managed node group, self-managed node group, and Fargate profile modules) from the project. In its place, users are encouraged to utilize the [`terraform-aws-eks`](https://github.com/terraform-aws-modules/terraform-aws-eks) module which meets or exceeds nearly all of the functionality of the EKS Blueprints v4.x cluster module. This includes the Terraform code contained at the root of the project as well as the `aws-eks-fargate-profiles`, `aws-eks-managed-node-groups`, `aws-eks-self-managed-node-groups`, and `launch-templates` modules which will all be removed from the project. | ||
| 2. The `aws-kms` module will be removed entirely. This was consumed in the root project module for cluster secret encryption. In its place, users can utilize the KMS key creation functionality of the [`terraform-aws-eks`](https://github.com/terraform-aws-modules/terraform-aws-eks) module or the [`terraform-aws-kms`](https://github.com/terraform-aws-modules/terraform-aws-kms) module if they wish to control the key separately from the cluster itself. | ||
| 3. The `emr-on-eks` module will be removed entirely; its replacement can be found in the addons under [`emr-on-eks`](https://github.com/aws-ia/terraform-aws-eks-blueprints/tree/main/modules/kubernetes-addons/emr-on-eks) and you can see an example of its usage under the [`emr-on-eks-fargate`](https://github.com/aws-ia/terraform-aws-eks-blueprints/tree/main/examples/analytics/emr-on-eks-fargate) example. |
There was a problem hiding this comment.
Let's update this will be replaced with new terraform module terraform-emr-eks-containers
bryantbiggs
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Error
bryantbiggs
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Error
bryantbiggs
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Failure
|
This PR has been automatically marked as stale because it has been open 30 days |
bryantbiggs
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Failure
|
shh - bad bot |
bryantbiggs
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Error
bryantbiggs
temporarily deployed
to
EKS Blueprints Test
GitHub Actions
Inactive
gminiba
pushed a commit
to gminiba/terraform-aws-eks-blueprints
that referenced
this pull request
May 26, 2023
…ty (aws-ia#1319) Co-authored-by: leighpascoe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.
Motivation
More
pre-commit run -awith this PRNote: Not all the PRs require a new example and/or doc page. In general:
docs/add-ons/*is required for new a new addonFor Moderators
Additional Notes