Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KMS key clean up #1040

Closed
1 task done
xincanva opened this issue Oct 10, 2022 · 2 comments
Closed
1 task done

KMS key clean up #1040

xincanva opened this issue Oct 10, 2022 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@xincanva
Copy link

Description

KMS key created as part of this module cannot be deleted by other admins.

[data.aws_iam_session_context.current.issuer_arn]

This has cause a lot of issues with clean up in our use case, where the original creator role may not be available.

can we add root to the principal list?

        "arn:${local.context.aws_partition_id}:iam::${local.context.aws_caller_identity_account_id}:root"

If your request is for a new feature, please use the Feature request template.

  • ✋ I have searched the open/closed issues and my issue is not listed.

⚠️ Note

Before you submit an issue, please perform the following first:

  1. Remove the local .terraform directory (! ONLY if state is stored remotely, which hopefully you are following that best practice!): rm -rf .terraform/
  2. Re-initialize the project root to pull down modules: terraform init
  3. Re-attempt your terraform plan or apply and check if the issue still persists

Versions

  • Module version [Required]:

  • Terraform version:

  • Provider version(s):

Reproduction Code [Required]

Steps to reproduce the behavior:

Expected behaviour

Actual behaviour

Terminal Output Screenshot(s)

Additional context

@askulkarni2
Copy link
Contributor

@xincanva you should be able to provide additional arns using cluster_kms_key_additional_admin_arns. See

variable "cluster_kms_key_additional_admin_arns" {

@bryantbiggs bryantbiggs added the bug Something isn't working label Oct 18, 2022
@bryantbiggs bryantbiggs added this to the v5.0 milestone Oct 18, 2022
@bryantbiggs
Copy link
Contributor

Closing for now - please see the guidance provided above by Apoorva as well as #1319 where the v19 of the terraform-aws-eks module handles this for users today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants