Update main.tf #1405
Update main.tf #1405
Conversation
haytham0123
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Failure
| @@ -126,7 +126,7 @@ module "eks_blueprints" { | |||
| public_ip = false # Use this to enable public IP for EC2 instances; only for public subnets used in launch templates | |||
|
|
|||
| http_endpoint = "enabled" | |||
| http_tokens = "optional" | |||
| http_tokens = "required" | |||
There was a problem hiding this comment.
to introduce IMDSv2 which is a security best practice
There was a problem hiding this comment.
Or we can have it as a variable please instead of being hard coded
There was a problem hiding this comment.
in the next iteration of blueprints, we will be utilizing the terraform-aws-eks module for cluster and node group creation and this module already has the default values set that you are looking for https://github.com/terraform-aws-modules/terraform-aws-eks/blob/a8e0de0b3f3a3e27232b35e9ed8814549273bced/node_groups.tf#L2-L6
|
thank you but we won't be making this change at this time. Next time, please start with an issue and we can discuss the problem we are trying to solve for and potential solutions before a PR |
What does this PR do?
🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.
Motivation
More
pre-commit run -awith this PRNote: Not all the PRs require a new example and/or doc page. In general:
docs/add-ons/*is required for new a new addonFor Moderators
Additional Notes