Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update main.tf #1405

Closed
wants to merge 1 commit into from
Closed

Update main.tf #1405

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/node-groups/managed-node-groups/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ module "eks_blueprints" {
public_ip = false # Use this to enable public IP for EC2 instances; only for public subnets used in launch templates

http_endpoint = "enabled"
http_tokens = "optional"
http_tokens = "required"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to introduce IMDSv2 which is a security best practice

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or we can have it as a variable please instead of being hard coded

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the next iteration of blueprints, we will be utilizing the terraform-aws-eks module for cluster and node group creation and this module already has the default values set that you are looking for https://github.com/terraform-aws-modules/terraform-aws-eks/blob/a8e0de0b3f3a3e27232b35e9ed8814549273bced/node_groups.tf#L2-L6

http_put_response_hop_limit = 3

# pre_userdata can be used in both cases where you provide custom_ami_id or ami_type
Expand Down