Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update ipv4-prefix-delegation example to use EKS v19 module #1298

Merged
merged 2 commits into from
Jan 6, 2023
Merged

feat: Update ipv4-prefix-delegation example to use EKS v19 module #1298

merged 2 commits into from
Jan 6, 2023

Conversation

bryantbiggs
Copy link
Contributor

What does this PR do?

  • Update ipv4-prefix-delegation example to use EKS v19 module

Motivation

  • Keeps example aligned with current practices and features of Amazon EKS

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bryantbiggs bryantbiggs requested a review from a team as a code owner January 6, 2023 20:54
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test January 6, 2023 21:06 — with GitHub Actions Inactive
Zvikan
Zvikan approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@Zvikan Zvikan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bryantbiggs bryantbiggs merged commit 2244230 into main Jan 6, 2023
@bryantbiggs bryantbiggs deleted the feat/update-prefix-delegation-example branch January 6, 2023 22:01
csantanapr
csantanapr reviewed Jan 6, 2023
View reviewed changes
Copy link
Contributor

@csantanapr csantanapr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Jan 10, 2023
@bryantbiggs @allamand
feat: Update ipv4-prefix-delegation example to use EKS v19 module (a…
2cf33da 
…ws-ia#1298)
vara-bonthu pushed a commit that referenced this pull request Feb 2, 2023
@bryantbiggs @vara-bonthu
feat: Update ipv4-prefix-delegation example to use EKS v19 module (#…
c19392e 
…1298)
@hustshawn
Copy link

@bryantbiggs may I know why this commit starts to use the EKS module directly, instead of the blueprints module?

@bryantbiggs
Copy link
Contributor Author

you can see more details here #1319

@hustshawn
Copy link

Thanks. it's good to know the team is targeting to a new direction. Looking forward to the v5 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csantanapr csantanapr csantanapr left review comments

@Zvikan Zvikan Zvikan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bryantbiggs @hustshawn @csantanapr @Zvikan